Merged
Conversation
Contributor
Author
|
One issue I found is that it is no longer possible to decide whether type is a SIMD vector solely from type. You also need type context. This means, for example, Or do you have a better idea? |
Contributor
|
This looks pretty good to me. Thanks for the patient revisions. Since I am less aware of what servo will need / want in this area (and haven't written SIMD code in years) perhaps @pcwalton should also take a look to confirm? |
Contributor
Author
|
Rebased. |
Contributor
|
Can we put the library parts in |
Contributor
|
sounds reasonable to locate |
Contributor
Author
|
Moved. |
Contributor
|
@sanxiyn I read over the patch. It looks pretty good to me so far. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment this only includes type checking and there is no code generation support yet. I wanted to get the design reviewed first.
From discussion with @graydon at #5841, re-implemented as
#[simd]attribute on structs.Progressing towards #3499.