When using value after move, point at span of local by estebank · Pull Request #57294 · rust-lang/rust

estebank · 2019-01-03T00:45:26Z

When trying to use a value after move, instead of using a note, point
at the local declaration that has a type that doesn't implement Copy
trait.

error[E0382]: use of moved value: `x`
  --> $DIR/issue-34721.rs:27:9
   |
LL |     pub fn baz<T: Foo>(x: T) -> T {
   |                -       - move occurs because `x` has type `T`, which does not implement the `Copy` trait
   |                |
   |                consider adding a `Copy` constraint to this type argument
LL |         if 0 == 1 {
LL |             bar::bar(x.zero())
   |                      - value moved here
LL |         } else {
LL |             x.zero()
   |             - value moved here
LL |         };
LL |         x.zero()
   |         ^ value used here after move

Fix #34721.

rust-highfive · 2019-01-03T00:45:29Z

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_mir/borrow_check/error_reporting.rs

estebank · 2019-01-07T18:33:16Z

@nikomatsakis, you might also be interested in taking a look at this.

nikomatsakis

I think this looks nice

src/librustc_mir/borrow_check/error_reporting.rs

estebank · 2019-01-10T19:26:02Z

Ping @eddyb :)

estebank · 2019-01-18T18:16:36Z

r? @nikomatsakis

src/librustc_mir/borrow_check/error_reporting.rs

estebank · 2019-01-21T23:09:49Z

@bors r=nikomatsakis

bors · 2019-01-21T23:09:49Z

📌 Commit 09006d8 has been approved by nikomatsakis

…sakis When using value after move, point at span of local When trying to use a value after move, instead of using a note, point at the local declaration that has a type that doesn't implement `Copy` trait. ``` error[E0382]: use of moved value: `x` --> $DIR/issue-34721.rs:27:9 | LL | pub fn baz<T: Foo>(x: T) -> T { | - - move occurs because `x` has type `T`, which does not implement the `Copy` trait | | | consider adding a `Copy` constraint to this type argument LL | if 0 == 1 { LL | bar::bar(x.zero()) | - value moved here LL | } else { LL | x.zero() | - value moved here LL | }; LL | x.zero() | ^ value used here after move ``` Fix rust-lang#34721.

bors · 2019-01-22T04:14:23Z

⌛ Testing commit 09006d8 with merge 1c661d9fc2c921cbd8f8baae786af49812562ad7...

bors · 2019-01-22T05:42:07Z

💔 Test failed - checks-travis

estebank · 2019-01-22T21:08:38Z

@bors r- need to update nll tests.

When trying to use a value after move, instead of using a note, point at the local declaration that has a type that doesn't implement `Copy` trait.

estebank · 2019-01-24T22:15:57Z

@bors r=nikomatsakis

bors · 2019-01-24T22:15:58Z

📌 Commit baa0828 has been approved by nikomatsakis

nikomatsakis · 2019-01-24T22:31:37Z

@bors r-

@estebank I never actually r+'d :)

nikomatsakis · 2019-01-24T22:32:13Z

@bors r+

However, it does seem fine. 😛

bors · 2019-01-24T22:32:13Z

📌 Commit baa0828 has been approved by nikomatsakis

estebank · 2019-01-24T22:39:39Z

@nikomatsakis I though I had seen green checkmark gated on fixing feedback, but looking now I must have gotten confused with a different PR, sorry about that 😬

…sakis When using value after move, point at span of local When trying to use a value after move, instead of using a note, point at the local declaration that has a type that doesn't implement `Copy` trait. ``` error[E0382]: use of moved value: `x` --> $DIR/issue-34721.rs:27:9 | LL | pub fn baz<T: Foo>(x: T) -> T { | - - move occurs because `x` has type `T`, which does not implement the `Copy` trait | | | consider adding a `Copy` constraint to this type argument LL | if 0 == 1 { LL | bar::bar(x.zero()) | - value moved here LL | } else { LL | x.zero() | - value moved here LL | }; LL | x.zero() | ^ value used here after move ``` Fix rust-lang#34721.

@ghost

Rollup of 5 pull requests Successful merges: - #56217 (Add grammar in docs for {f32,f64}::from_str, mention known bug.) - #57294 (When using value after move, point at span of local) - #57652 (Update/remove some old readmes) - #57802 (Print visible name for types as well as modules.) - #57865 (Don't ICE when logging unusual types) Failed merges: r? @ghost

rust-highfive assigned eddyb Jan 3, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 3, 2019

This comment has been minimized.

Sign in to view

estebank force-pushed the point-copy-less branch from 19a3c07 to abbf5a2 Compare January 6, 2019 23:23

estebank commented Jan 7, 2019

View reviewed changes

src/librustc_mir/borrow_check/error_reporting.rs Outdated Show resolved Hide resolved

nikomatsakis approved these changes Jan 9, 2019

View reviewed changes

src/librustc_mir/borrow_check/error_reporting.rs Outdated Show resolved Hide resolved

rust-highfive assigned nikomatsakis and unassigned eddyb Jan 18, 2019

nikomatsakis requested changes Jan 18, 2019

View reviewed changes

src/librustc_mir/borrow_check/error_reporting.rs Outdated Show resolved Hide resolved

nikomatsakis added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2019

estebank force-pushed the point-copy-less branch from abbf5a2 to 09006d8 Compare January 18, 2019 23:47

estebank added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 18, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2019

Centril mentioned this pull request Jan 21, 2019

Rollup of 8 pull requests #57823

Closed

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2019

estebank added 6 commits January 24, 2019 10:36

When using value after move, point at span of local

5e9c8d7

When trying to use a value after move, instead of using a note, point at the local declaration that has a type that doesn't implement `Copy` trait.

Add test for rust-lang#34721

e0a606c

break eagerly from loop

f6e29ba

Point at type argument suggesting adding Copy constraint

0e2d6e0

review comments

29e8e63

Fix --compare-mode=nll tests

baa0828

estebank force-pushed the point-copy-less branch from 09006d8 to baa0828 Compare January 24, 2019 18:54

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 24, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2019

nikomatsakis approved these changes Jan 24, 2019

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 24, 2019

Centril mentioned this pull request Jan 25, 2019

Rollup of 5 pull requests #57888

Merged

bors merged commit baa0828 into rust-lang:master Jan 25, 2019

pnkfelix mentioned this pull request Mar 4, 2019

Compiler panic with associated constant #58435

Closed

Uh oh!

Conversation

estebank commented Jan 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Jan 3, 2019

Uh oh!

This comment has been minimized.

Uh oh!

estebank commented Jan 7, 2019

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

estebank commented Jan 10, 2019

Uh oh!

estebank commented Jan 18, 2019

Uh oh!

Uh oh!

estebank commented Jan 21, 2019

Uh oh!

bors commented Jan 21, 2019

Uh oh!

bors commented Jan 22, 2019

Uh oh!

bors commented Jan 22, 2019

Uh oh!

estebank commented Jan 22, 2019

Uh oh!

estebank commented Jan 24, 2019

Uh oh!

bors commented Jan 24, 2019

Uh oh!

nikomatsakis commented Jan 24, 2019

Uh oh!

nikomatsakis commented Jan 24, 2019

Uh oh!

bors commented Jan 24, 2019

Uh oh!

estebank commented Jan 24, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

estebank commented Jan 3, 2019 •

edited

Loading