[do not merge] Revert "Convert SerializedDepGraph to be a struct-of-arrays"#57070
Closed
Zoxc wants to merge 1 commit intorust-lang:masterfrom
Closed
[do not merge] Revert "Convert SerializedDepGraph to be a struct-of-arrays"#57070Zoxc wants to merge 1 commit intorust-lang:masterfrom
Zoxc wants to merge 1 commit intorust-lang:masterfrom
Conversation
Contributor
Author
|
@bors try |
Collaborator
|
⌛ Trying commit ce7ee686c8d176013a8e3767c5a2d6a71cb9ba13 with merge 9db7021220dfbb6d33d8db1c1f1310a3bc4a1144... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - status-travis |
This comment has been minimized.
This comment has been minimized.
This reverts commit c43b1a0.
Contributor
Author
|
@bors try |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 23, 2018
[do not merge] Revert "Convert SerializedDepGraph to be a struct-of-arrays" Let's check if #49069 was actually helpful. r? @michaelwoerister
Collaborator
|
☀️ Test successful - status-travis |
Contributor
Author
|
@rust-timer build d453555 |
Collaborator
|
Success: Queued d453555 with parent 2d3e909, comparison URL. |
Collaborator
|
Finished benchmarking try commit d453555 |
Contributor
Author
|
This doesn't seem to have much of an impact, but if it shifts computation to dep graph serialization it could still be beneficial to revert this for parallel queries. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's check if #49069 was actually helpful.
r? @michaelwoerister