rename div_euc -> div_euclid, and mod_euc -> rem_euclid by strega-nil · Pull Request #56936 · rust-lang/rust

strega-nil · 2018-12-18T00:45:02Z

logic is written up in #49048

Also, update the documentation slightly.

cc @alexcrichton @clarcharr @varkor

logic is written up in #49048 Also, update the documentation slightly

rust-highfive · 2018-12-18T00:45:13Z

r? @dtolnay

(rust_highfive has picked a reviewer for you, use r? to override)

clarfonthey · 2018-12-18T01:10:16Z

Thank you for the PR!

rust-highfive · 2018-12-18T01:50:28Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:051638c8:start=1545094002714405624,finish=1545094059512726135,duration=56798320511
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/63/dc/c8bfd1bd77113c033161ce31730510d1c479cf9bcc8e99edf3c906f30cce/awscli-1.16.77-py2.py3-none-any.whl (1.4MB)
    0% |▎                               | 10kB 30.1MB/s eta 0:00:01
    1% |▌                               | 20kB 2.1MB/s eta 0:00:01
    2% |▊                               | 30kB 3.1MB/s eta 0:00:01
    2% |█                               | 40kB 2.0MB/s eta 0:00:01
---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-both (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:51:47] 
[00:51:47] running 119 tests
[00:52:09] .iiiii...i.....i..i...i..i.i..i.ii..i.....i..i....i..........iiii.........i.i...ii...i.......ii.i.i. 100/119
[00:52:13] i......iii.i.....ii
[00:52:13] 
[00:52:13]  finished in 26.291
[00:52:13] travis_fold:end:test_debuginfo

---
[01:02:21] travis_fold:start:test_stage1-core
travis_time:start:test_stage1-core
Testing core stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:02:21]    Compiling core v0.0.0 (/checkout/src/libcore)
[01:02:30] error[E0599]: no method named `mod_euclid` found for type `i8` in the current scope
[01:02:30]   --> src/libcore/../libcore/tests/num/int_macros.rs:35:28
[01:02:30]    |
[01:02:30] 35 |         assert!((-1 as $T).mod_euclid(MIN) == MAX);
[01:02:30]    | 
[01:02:30]    | 
[01:02:30]   ::: src/libcore/../libcore/tests/num/i8.rs:11:1
[01:02:30]    |
[01:02:30] 11 | int_module!(i8, i8);
[01:02:30]    | -------------------- in this macro invocation
[01:02:30]    |
[01:02:30]    = help: did you mean `div_euclid`?
[01:02:30] 
[01:02:30] error[E0599]: no method named `mod_euclid` found for type `i16` in the current scope
[01:02:30]   --> src/libcore/../libcore/tests/num/int_macros.rs:35:28
[01:02:30]    |
[01:02:30] 35 |         assert!((-1 as $T).mod_euclid(MIN) == MAX);
[01:02:30]    | 
[01:02:30]    | 
[01:02:30]   ::: src/libcore/../libcore/tests/num/i16.rs:11:1
[01:02:30]    |
[01:02:30] 11 | int_module!(i16, i16);
[01:02:30]    | ---------------------- in this macro invocation
[01:02:30]    |
[01:02:30]    = help: did you mean `div_euclid`?
[01:02:30] 
[01:02:30] error[E0599]: no method named `mod_euclid` found for type `i32` in the current scope
[01:02:30]   --> src/libcore/../libcore/tests/num/int_macros.rs:35:28
[01:02:30]    |
[01:02:30] 35 |         assert!((-1 as $T).mod_euclid(MIN) == MAX);
[01:02:30]    | 
[01:02:30]    | 
[01:02:30]   ::: src/libcore/../libcore/tests/num/i32.rs:11:1
[01:02:30]    |
[01:02:30] 11 | int_module!(i32, i32);
[01:02:30]    | ---------------------- in this macro invocation
[01:02:30]    |
[01:02:30]    = help: did you mean `div_euclid`?
[01:02:30] 
[01:02:30] error[E0599]: no method named `mod_euclid` found for type `i64` in the current scope
[01:02:30]   --> src/libcore/../libcore/tests/num/int_macros.rs:35:28
[01:02:30]    |
[01:02:30] 35 |         assert!((-1 as $T).mod_euclid(MIN) == MAX);
[01:02:30]    | 
[01:02:30]    | 
[01:02:30]   ::: src/libcore/../libcore/tests/num/i64.rs:11:1
[01:02:30]    |
[01:02:30] 11 | int_module!(i64, i64);
[01:02:30]    | ---------------------- in this macro invocation
[01:02:30]    |
[01:02:30]    = help: did you mean `div_euclid`?
---
travis_time:end:0c12f4e0:start=1545097825543383064,finish=1545097825627330932,duration=83947868
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:065937de
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:012b27b6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libcore/num/mod.rs

dtolnay · 2018-12-20T07:09:02Z

Implementation looks good to me. Let's run these names by @rust-lang/libs in case other people have opinions.

Notice there are two changes:

euc -> euclid
mod -> rem

Co-Authored-By: ubsan <npmazzuca@gmail.com>

dtolnay · 2018-12-21T03:41:34Z

@bors r+

bors · 2018-12-21T03:41:35Z

📌 Commit 455bc95 has been approved by dtolnay

@alexcrichton

rename div_euc -> div_euclid, and mod_euc -> rem_euclid logic is written up in rust-lang#49048 Also, update the documentation slightly. cc @alexcrichton @clarcharr @varkor

@alexcrichton

rename div_euc -> div_euclid, and mod_euc -> rem_euclid logic is written up in rust-lang#49048 Also, update the documentation slightly. cc @alexcrichton @clarcharr @varkor

Rollup of 25 pull requests Successful merges: - #56802 (Add DoubleEndedIterator::nth_back) - #56909 (static eval: Do not ICE on layout size overflow) - #56914 (Ignore ui/target-feature-gate on sparc, sparc64, powerpc, powerpc64 and powerpc64le) - #56919 (Remove a wrong multiplier on relocation offset computation) - #56933 (Add --progress to git submodule commands in x.py) - #56936 (rename div_euc -> div_euclid, and mod_euc -> rem_euclid) - #56941 (deny intra-doc link resolution failures in libstd) - #56945 (Fix rustdoc-js tests) - #56967 (Replace current crate's searchIndex when regenerating) - #56970 (Mem uninit doc ptr drop) - #56973 (make basic CTFE tracing available on release builds) - #56979 (Adding unwinding support for x86_64_fortanix_unknown_sgx target.) - #56981 (miri: allocation is infallible) - #56984 (A few tweaks to dropck_outlives) - #56989 (Fix compiletest `trim` deprecation warnings) - #56992 (suggest similar lint names for unknown lints) - #57002 (Stabilize Vec(Deque)::resize_with) - #57011 (rustdoc: add new CLI flag to load static files from a different location) - #57027 (Optimize away a move) - #57034 (Inline tweaks) - #57039 (Update migrate warning wording.) - #57040 (Fix feature gate to point to 1.32.0 for `path_from_str`) - #57049 (Stabilize #[repr(packed(N))]) - #57050 (Fixed typo in HashMap documentation) - #57052 (Fix stabilization version numbers (exhaustive_integer_patterns + macro_literal_matcher))

rust-lang/rust#56936

rename div_euc -> div_euclid, and mod_euc -> rem_euclid

e36b628

logic is written up in #49048 Also, update the documentation slightly

rust-highfive assigned dtolnay Dec 18, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 18, 2018

kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 18, 2018

fix tests

de39aea

dtolnay reviewed Dec 20, 2018

View reviewed changes

src/libcore/num/mod.rs Show resolved Hide resolved

src/libcore/num/mod.rs Outdated Show resolved Hide resolved

dtolnay and others added 2 commits December 20, 2018 01:34

Update src/libcore/num/mod.rs

66bb34c

Co-Authored-By: ubsan <npmazzuca@gmail.com>

fix nits

455bc95

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2018

Centril mentioned this pull request Dec 22, 2018

Rollup of 41 pull requests #57058

Closed

kennytm mentioned this pull request Dec 22, 2018

Rollup of 25 pull requests #57063

Merged

bors merged commit 455bc95 into rust-lang:master Dec 23, 2018

edarc added a commit to edarc/ssd1322 that referenced this pull request Jan 20, 2019

Fix build breakage following Rust unstable method renames.

70e914b

rust-lang/rust#56936

varkor mentioned this pull request Feb 3, 2019

Tracking issue for RFC 2169: Euclidean Modulo #49048

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rename div_euc -> div_euclid, and mod_euc -> rem_euclid#56936

rename div_euc -> div_euclid, and mod_euc -> rem_euclid#56936
bors merged 4 commits intorust-lang:masterfrom
strega-nil:euclidean_div_rem

strega-nil commented Dec 18, 2018

Uh oh!

rust-highfive commented Dec 18, 2018

Uh oh!

clarfonthey commented Dec 18, 2018

Uh oh!

rust-highfive commented Dec 18, 2018

Uh oh!

Uh oh!

Uh oh!

dtolnay commented Dec 20, 2018

Uh oh!

dtolnay commented Dec 21, 2018

Uh oh!

bors commented Dec 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

strega-nil commented Dec 18, 2018

Uh oh!

rust-highfive commented Dec 18, 2018

Uh oh!

clarfonthey commented Dec 18, 2018

Uh oh!

rust-highfive commented Dec 18, 2018

Uh oh!

Uh oh!

Uh oh!

dtolnay commented Dec 20, 2018

Uh oh!

dtolnay commented Dec 21, 2018

Uh oh!

bors commented Dec 21, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants