Skip to content

Put all existential ty vars in the ROOT universe#56251

Merged
bors merged 1 commit intorust-lang:masterfrom
scalexm:root-universe
Nov 27, 2018
Merged

Put all existential ty vars in the ROOT universe#56251
bors merged 1 commit intorust-lang:masterfrom
scalexm:root-universe

Conversation

@scalexm
Copy link
Contributor

@scalexm scalexm commented Nov 26, 2018

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2018
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 26, 2018

@bors try

@bors
Copy link
Collaborator

bors commented Nov 26, 2018

⌛ Trying commit efb2949 with merge 65100c5...

bors added a commit that referenced this pull request Nov 26, 2018
@bors
Auto merge of #56251 - scalexm:root-universe, r=<try>
65100c5 
Put all existential ty vars in the `ROOT` universe

r? @nikomatsakis
@bors
Copy link
Collaborator

bors commented Nov 26, 2018

☀️ Test successful - status-travis
State: approved= try=True

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 26, 2018

@rust-timer build 65100c5

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 26, 2018

Success: Queued 65100c5 with parent 6bfb46e, comparison URL.

@rust-timer
Copy link
Collaborator

rust-timer commented Nov 27, 2018

Finished benchmarking try commit 65100c5

@memoryruins memoryruins mentioned this pull request Nov 27, 2018
Closed
@nikic nikic mentioned this pull request Nov 27, 2018
Closed
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 27, 2018

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Nov 27, 2018

📌 Commit efb2949 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2018
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 27, 2018

Giving p=1 because this fixes a massive perf regression.

@bors
Copy link
Collaborator

bors commented Nov 27, 2018

⌛ Testing commit efb2949 with merge aeff91d...

bors added a commit that referenced this pull request Nov 27, 2018
@bors
Auto merge of #56251 - scalexm:root-universe, r=nikomatsakis
aeff91d 
Put all existential ty vars in the `ROOT` universe

r? @nikomatsakis
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 27, 2018

@scalexm do you know whether the commit that caused problems is on beta?

@scalexm
Copy link
Contributor Author

scalexm commented Nov 27, 2018

@nikomatsakis it isn't

@bors
Copy link
Collaborator

bors commented Nov 27, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing aeff91d to master...

@bors bors merged commit efb2949 into rust-lang:master Nov 27, 2018
@bors bors mentioned this pull request Nov 27, 2018
Merged
@scalexm scalexm deleted the root-universe branch November 27, 2018 19:06
@bors bors mentioned this pull request Nov 27, 2018
Merged
@pnkfelix pnkfelix mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nikomatsakis nikomatsakis

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@scalexm @nikomatsakis @bors @rust-timer @rust-highfive