[rustdoc] Add lint for doc without codeblocks#54349
Merged
bors merged 3 commits intorust-lang:masterfrom Oct 18, 2018
Merged
Conversation
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
7aa21cd to
1256963
Compare
Contributor
QuietMisdreavus
left a comment
There was a problem hiding this comment.
Nice! Just a couple comments and this looks good.
I wonder whether it's possible to copy out some of the lint registration mechanisms and start hosting them ourselves.
src/librustc/lint/builtin.rs
Outdated
Contributor
There was a problem hiding this comment.
This may work better as MISSING_DOC_CODE_EXAMPLES - users don't need to care about the fact that docs go on items, and making it plural fits in better with other lints.
Member
Author
There was a problem hiding this comment.
I indeed prefer the new proposition. :)
1256963 to
f23cda1
Compare
Member
Author
|
Updated. |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
f23cda1 to
47872ad
Compare
Member
Author
|
And removed unwanted change. All ready to go now! |
Contributor
|
Thanks! Can you add a test? Sorry for not noticing earlier. |
47872ad to
c0b7b6e
Compare
Member
Author
|
Rebased and added the test. |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
c0b7b6e to
26479c4
Compare
Member
Author
|
And fixed tidy. |
QuietMisdreavus
approved these changes
Oct 17, 2018
Contributor
|
Thanks so much! @bors r+ |
Collaborator
|
📌 Commit 26479c4 has been approved by |
Collaborator
|
⌛ Testing commit 26479c4 with merge 021f0915c2b3f12a0b64cb96d90c40377edf64f2... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
|
@bors retry Linker SIGILL |
Collaborator
|
⌛ Testing commit 26479c4 with merge 151e4590f5fdb15fd6f8780e881eb5fb9ed8af58... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
Collaborator
bors
added a commit
that referenced
this pull request
Oct 18, 2018
[rustdoc] Add lint for doc without codeblocks Fixes #53805. r? @QuietMisdreavus
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53805.
r? @QuietMisdreavus