Fix promotion stability hole in old borrowck by oli-obk · Pull Request #53699 · rust-lang/rust

oli-obk · 2018-08-25T13:35:40Z

I screwed up the promotion stability checks. Big time. They were basically nonexistant. We had tests for it. I also screwed up said tests. This is in stable already :(

Basically stability checks of promotion only worked if you tried to use a const fn defined in the same crate.

cc @eddyb

rust-highfive · 2018-08-25T13:49:42Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.


[00:04:44] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:45] tidy error: /checkout/src/test/ui/consts/const-eval/auxiliary/stability.rs: missing trailing newline
[00:04:46] some tidy checks failed
[00:04:46] 
[00:04:46] 
[00:04:46] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:46] 
[00:04:46] 
[00:04:46] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:46] Build completed unsuccessfully in 0:00:50
[00:04:46] Build completed unsuccessfully in 0:00:50
[00:04:46] Makefile:79: recipe for target 'tidy' failed
[00:04:46] make: *** [tidy] Error 1

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:025bf1dd
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:045b0f40:start=1535204530475625103,finish=1535204530484080111,duration=8455008
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:00646ed0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:197fb05a
travis_time:start:197fb05a
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:07789a36
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Mark-Simulacrum · 2018-08-25T15:40:23Z

@bors try for crater

bors · 2018-08-25T15:40:35Z

⌛ Trying commit 2d2b69d with merge bc5a74802bb3ffc82f51ef04bca58d64220124c4...

bors · 2018-08-25T17:36:37Z

☀️ Test successful - status-travis
State: approved= try=True

emilyalbini · 2018-08-26T07:23:49Z

@craterbot run start=master#545f22340f72ee0efaf6463efb43a2840e3d35db end=try#bc5a74802bb3ffc82f51ef04bca58d64220124c4 mode=check-only

craterbot · 2018-08-26T07:23:50Z

👌 Experiment pr-53699 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

emilyalbini · 2018-08-27T18:44:39Z

@craterbot p=1

craterbot · 2018-08-27T18:44:44Z

📝 Configuration of the pr-53699 experiment changed.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-08-29T13:59:25Z

🚧 Experiment pr-53699 is now running on agent crater-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2018-08-31T01:26:06Z

🎉 Experiment pr-53699 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

oli-obk · 2018-08-31T07:20:26Z

The one regression does not show any errors except for "compilation failed"... I presume spurious (passes locally)

@bors r=nikomatsakis p=1 (fixes stability hole)

bors · 2018-08-31T07:20:27Z

📌 Commit 2d2b69d has been approved by nikomatsakis

bors · 2018-08-31T07:20:51Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: [beta] const eval perf regression fix #53825

bors · 2018-08-31T07:20:52Z

📌 Commit 2d2b69d has been approved by nikomatsakis

bors · 2018-08-31T08:52:10Z

⌛ Testing commit 2d2b69d with merge a433cc8cf3b2b2adc38800eac2276bc670598b91...

bors · 2018-08-31T11:25:48Z

💔 Test failed - status-travis

rust-highfive · 2018-08-31T11:25:49Z

The job dist-x86_64-apple of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

uploading "a433cc8cf3b2b2adc38800eac2276bc670598b91/rust-docs-nightly-i386-apple-ios.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "a433cc8cf3b2b2adc38800eac2276bc670598b91/rust-docs-nightly-armv7s-apple-ios.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
uploading "a433cc8cf3b2b2adc38800eac2276bc670598b91/rust-docs-nightly-armv7s-apple-ios.tar.gz" with {:content_type=>"application/gzip", :acl=>"public-read"}
uploading "a433cc8cf3b2b2adc38800eac2276bc670598b91/rust-docs-nightly-armv7-apple-ios.tar.xz" with {:content_type=>"application/x-xz", :acl=>"public-read"}
/Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.121/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:81:in `abort_upload': multipart upload failed: execution expired (Aws::S3::MultipartUploadError)
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.121/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:70:in `upload_parts'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.121/lib/aws-sdk-resources/services/s3/multipart_file_uploader.rb:44:in `upload'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.121/lib/aws-sdk-resources/services/s3/file_uploader.rb:32:in `upload'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/aws-sdk-resources-2.11.121/lib/aws-sdk-resources/services/s3/object.rb:252:in `upload_file'
 from /Users/travis/.rvm/gems/ruby-2.4.2/gems/dpl-s3-1.10.0/lib/dpl/provider/s3.rb:99:in `block (2 levels) in upload_multithreaded'
failed to deploy
failed to deploy
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2018-08-31T11:32:15Z

@bors retry (build succeeded, upload failed)

bors · 2018-08-31T14:06:21Z

⌛ Testing commit 2d2b69d with merge 163adf2...

@nikomatsakis

Fix promotion stability hole in old borrowck r? @nikomatsakis I screwed up the promotion stability checks. Big time. They were basically nonexistant. We had tests for it. I also screwed up said tests. This is in stable already :( Basically stability checks of promotion only worked if you tried to use a const fn defined in the same crate. cc @eddyb

bors · 2018-08-31T17:39:21Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 163adf2 to master...

@nikomatsakis

[beta] Properly prevent the promotion of unstable const fns backport of #53699 r? @nikomatsakis (the other PR was merged and beta nominated but not beta approved)

oli-obk added 2 commits August 25, 2018 14:58

Properly prevent the promotion of unstable const fns

458f5a2

Check cross crate stability of const fn

dba1c71

oli-obk added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 25, 2018

rust-highfive assigned nikomatsakis Aug 25, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 25, 2018

Satisfy tidy

2d2b69d

emilyalbini added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 25, 2018

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2018

TimDiekmann mentioned this pull request Aug 26, 2018

Add more const int ops #53697

Merged

nikomatsakis approved these changes Aug 27, 2018

View reviewed changes

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 31, 2018

TimDiekmann mentioned this pull request Aug 31, 2018

Tracking Issue for more const int functions #53718

Closed

59 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 31, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2018

bors merged commit 2d2b69d into rust-lang:master Aug 31, 2018

TimDiekmann mentioned this pull request Sep 1, 2018

const fn integer operations #51299

Merged

oli-obk mentioned this pull request Sep 4, 2018

[beta] Properly prevent the promotion of unstable const fns #53944

Merged

bors added a commit that referenced this pull request Sep 4, 2018

Auto merge of #53944 - oli-obk:beta, r=nikomatsakis

4dcf42f

[beta] Properly prevent the promotion of unstable const fns backport of #53699 r? @nikomatsakis (the other PR was merged and beta nominated but not beta approved)

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Sep 5, 2018

oli-obk deleted the promotion_stability_hole branch June 15, 2020 15:28

Uh oh!

Conversation

oli-obk commented Aug 25, 2018

Uh oh!

rust-highfive commented Aug 25, 2018

Uh oh!

Mark-Simulacrum commented Aug 25, 2018

Uh oh!

bors commented Aug 25, 2018

Uh oh!

bors commented Aug 25, 2018

Uh oh!

emilyalbini commented Aug 26, 2018

Uh oh!

craterbot commented Aug 26, 2018

Uh oh!

emilyalbini commented Aug 27, 2018

Uh oh!

craterbot commented Aug 27, 2018

Uh oh!

craterbot commented Aug 29, 2018

Uh oh!

craterbot commented Aug 31, 2018

Uh oh!

oli-obk commented Aug 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

rust-highfive commented Aug 31, 2018

Uh oh!

oli-obk commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

bors commented Aug 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

oli-obk commented Aug 31, 2018 •

edited

Loading