Skip to content

Lower case some feature gate error messages#51799

Merged
bors merged 1 commit intorust-lang:masterfrom
mark-i-m:lower_case_feature_gate
Jun 28, 2018
Merged

Lower case some feature gate error messages#51799
bors merged 1 commit intorust-lang:masterfrom
mark-i-m:lower_case_feature_gate

Conversation

@mark-i-m
Copy link
Contributor

@mark-i-m mark-i-m commented Jun 26, 2018

No description provided.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 26, 2018

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2018
@zackmdavis
Copy link
Contributor

zackmdavis commented Jun 26, 2018

This could be squashed into one commit.

@petrochenkov
Copy link
Contributor

petrochenkov commented Jun 26, 2018

r=me after squashing
@bors delegate+

@bors
Copy link
Collaborator

bors commented Jun 26, 2018

✌️ @mark-i-m can now approve this pull request

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2018
@mark-i-m mark-i-m force-pushed the lower_case_feature_gate branch from f8446af to 2abca0d Compare June 27, 2018 00:05
@mark-i-m mark-i-m force-pushed the lower_case_feature_gate branch from 2abca0d to 9f6bdb9 Compare June 27, 2018 00:06
@mark-i-m
Copy link
Contributor Author

mark-i-m commented Jun 27, 2018

Squashed. Will wait for travis. Then r+

@mark-i-m
Copy link
Contributor Author

mark-i-m commented Jun 27, 2018

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 27, 2018

📌 Commit 9f6bdb9 has been approved by mark-i-m

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 27, 2018
@bors
Copy link
Collaborator

bors commented Jun 27, 2018

⌛ Testing commit 9f6bdb9 with merge a50bdee8c46dec974d219c492bbdc79cde613289...

@bors
Copy link
Collaborator

bors commented Jun 27, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 27, 2018
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 27, 2018

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:07:10] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:589:17
[01:07:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/tools/rls src/tools/rustfmt src/tools/miri src/tools/clippy
[01:07:10] Build completed unsuccessfully in 1:04:20
[01:07:10] {"miri":"test-pass","clippy-driver":"test-pass","rust-by-example":"test-pass","rustfmt":"test-pass","book":"test-pass","reference":"test-pass","rls":"test-pass","nomicon":"test-pass"}
[01:07:10] Verifying status of book...
---
travis_time:end:06770e00:start=1530083686967287405,finish=1530083686972872661,duration=5585256
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0e00674c
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01a58d38
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

1 similar comment
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 27, 2018

The job x86_64-gnu-tools of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
  0     0    0     0    0     0      0      0 --:--:--  0:00:51 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:52 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:53 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:54 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:55 --:--:--     0curl: (6) Could not resolve host: s3-us-west-1.amazonaws.com
[01:07:10] thread 'main' panicked at 'failed to download openssl source: exit code: 6', bootstrap/native.rs:589:17
[01:07:10] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --no-fail-fast src/doc/book src/doc/nomicon src/doc/reference src/doc/rust-by-example src/tools/rls src/tools/rustfmt src/tools/miri src/tools/clippy
[01:07:10] Build completed unsuccessfully in 1:04:20
[01:07:10] {"miri":"test-pass","clippy-driver":"test-pass","rust-by-example":"test-pass","rustfmt":"test-pass","book":"test-pass","reference":"test-pass","rls":"test-pass","nomicon":"test-pass"}
[01:07:10] Verifying status of book...
---
travis_time:end:06770e00:start=1530083686967287405,finish=1530083686972872661,duration=5585256
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0e00674c
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:01a58d38
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@kennytm
Copy link
Member

kennytm commented Jun 27, 2018

@bors retry travis-ci/travis-ci#9696

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 27, 2018
@emilyalbini
Copy link
Member

emilyalbini commented Jun 27, 2018

@bors rollup

kennytm added a commit to kennytm/rust that referenced this pull request Jun 27, 2018
@kennytm
Rollup merge of rust-lang#51799 - mark-i-m:lower_case_feature_gate, r…
770d0fb 
…=mark-i-m

Lower case some feature gate error messages
@kennytm kennytm mentioned this pull request Jun 27, 2018
Merged
bors added a commit that referenced this pull request Jun 27, 2018
@bors
Auto merge of #51859 - kennytm:rollup, r=kennytm
266afeb 
Rollup of 7 pull requests

Successful merges:

 - #49987 (Add str::split_ascii_whitespace.)
 - #50342 (Document round-off error in `.mod_euc()`-method, see issue #50179)
 - #51658 (Only do sanity check with debug assertions on)
 - #51799 (Lower case some feature gate error messages)
 - #51800 (Add a compiletest header for edition)
 - #51824 (Fix the error reference for LocalKey::try_with)
 - #51842 (Document that Layout::from_size_align does not allow align=0)

Failed merges:

r? @ghost
@bors bors merged commit 9f6bdb9 into rust-lang:master Jun 28, 2018
@mark-i-m mark-i-m deleted the lower_case_feature_gate branch November 14, 2018 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mark-i-m @rust-highfive @zackmdavis @petrochenkov @bors @kennytm @emilyalbini