Skip to content

Fix --disable-optimize-llvm#5134

Closed
brson wants to merge 1 commit into
rust-lang:incomingfrom
brson:disable-optimize-llvm
Closed

Fix --disable-optimize-llvm#5134
brson wants to merge 1 commit into
rust-lang:incomingfrom
brson:disable-optimize-llvm

Conversation

@brson

@brson brson commented Feb 27, 2013

Copy link
Copy Markdown
Contributor

No description provided.

@bors bors closed this Feb 27, 2013
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2020
Make it possible to correctly indent snippet_block snippets

This adds a `indent_relative_to` arg to the `{snippet,expr}_block` functions. This makes it possible to keep the correct indentation of block like suggestions.

In addition, this makes the `trim_multiline` function private and adds a `indent_of` function, to get the indentation of the first line of a span.

The suggestion of `needless_continue` cannot be made auto applicable, since it would be also necessary to remove code following the linted expression. (Well, maybe it is possible, but I don't know how to do it. Expanding the suggestion span to the last expression, that should be removed didn't work)

changelog: Improve suggestions, when blocks of code are involved
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants