restore emplacement syntax (obsolete) by nikomatsakis · Pull Request #51052 · rust-lang/rust

nikomatsakis · 2018-05-24T22:51:05Z

rust-highfive · 2018-05-24T23:03:36Z

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/03/9d/a0b73320e4b9d776b0b68a67c7dbdc4115eb9eceff992d6b56222ba550d3/awscli-1.15.27-py2.py3-none-any.whl (1.3MB)
    0% |▎                               | 10kB 23.6MB/s eta 0:00:01
    1% |▌                               | 20kB 2.0MB/s eta 0:00:01
    2% |▉                               | 30kB 2.3MB/s eta 0:00:01
    3% |█                               | 40kB 2.0MB/s eta 0:00:01
---
    100% |████████████████████████████████| 552kB 2.1MB/s 
Collecting botocore==1.10.27 (from awscli)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/0a/fc/5dbeb052f4b70346ad3eb1ac291d503c0a28ed7e0f806f7337bbb73e3b76/botocore-1.10.27-py2.py3-none-any.whl (4.2MB)
    0% |                                | 10kB 31.0MB/s eta 0:00:01
    0% |▏                               | 20kB 32.7MB/s eta 0:00:01
    0% |▎                               | 30kB 38.3MB/s eta 0:00:01
    0% |▎                               | 40kB 40.1MB/s eta 0:00:01
---

[00:05:56] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:05:56] tidy error: /checkout/src/librustc_passes/ast_validation.rs:178: line longer than 100 chars
[00:05:58] some tidy checks failed
[00:05:58] 
[00:05:58] 
[00:05:58] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:05:58] 
[00:05:58] 
[00:05:58] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:05:58] Build completed unsuccessfully in 0:02:35
[00:05:58] Build completed unsuccessfully in 0:02:35
[00:05:58] make: *** [tidy] Error 1
[00:05:58] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:0e3efc80
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

petrochenkov · 2018-05-24T23:03:51Z

src/libsyntax/parse/parser.rs

                let (span, e) = self.interpolated_or_expr_span(e)?;
                (lo.to(span), ExprKind::AddrOf(m, e))
            }
+            token::Ident(..) if self.token.is_keyword(keywords::In) => {


Wat.
I thought we removed the in version, like, years ago.

Nope, it was removed in @aidanhs's PR

petrochenkov · 2018-05-24T23:04:36Z

src/librustc_passes/ast_validation.rs

+            ExprKind::ObsoleteInPlace(..) => {
+                self.err_handler()
+                    .struct_span_err(expr.span, "emplacement syntax is obsolete (for now, anyway)")
+                    .note("for more information, see <https://github.com/rust-lang/rust/issues/27779#issuecomment-378416911>")


petrochenkov · 2018-05-24T23:04:56Z

r=me after fixing tidy

nikomatsakis · 2018-05-25T12:29:28Z

@bors r=petrochenkov

bors · 2018-05-25T12:29:29Z

📌 Commit 626818f has been approved by petrochenkov

emilyalbini · 2018-05-26T11:44:49Z

@bors p=1 (needs to be backported to beta)

bors · 2018-05-26T14:30:37Z

⌛ Testing commit 626818f with merge 1594c6c...

@petrochenkov

restore emplacement syntax (obsolete) Fix #50832 r? @petrochenkov

bors · 2018-05-26T16:56:17Z

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 1594c6c to master...

@ghost

[beta] Process backports Merged and approved: * #50812: Fix issue #50811 (`NaN > NaN` was true). * #50827: Update LLVM to `56c931901cfb85cd6f7ed44c7d7520a8de1edf97` * #50879: Fix naming conventions for new lints * #51011: rustdoc: hide macro export statements from docs * #51051: prohibit turbofish in `impl Trait` methods * #51052: restore emplacement syntax (obsolete) * #51146: typeck: Do not pass the field check on field error * #51235: remove notion of Implicit derefs from mem-cat r? @ghost

@ghost

[beta] Process backports Merged and approved: * #50812: Fix issue #50811 (`NaN > NaN` was true). * #50879: Fix naming conventions for new lints * #51011: rustdoc: hide macro export statements from docs * #51051: prohibit turbofish in impl Trait methods * #51052: restore emplacement syntax (obsolete) * #51146: typeck: Do not pass the field check on field error * #51235: remove notion of Implicit derefs from mem-cat r? @ghost

restore emplacement syntax (obsolete)

01d6ed5

rust-highfive assigned petrochenkov May 24, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2018

nikomatsakis mentioned this pull request May 24, 2018

Crates using placement syntax behind a cfg broken #50832

Closed

petrochenkov reviewed May 24, 2018

View reviewed changes

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 25, 2018

pacify the mercilous tidy

626818f

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2018

emilyalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label May 26, 2018

bors added a commit that referenced this pull request May 26, 2018

Auto merge of #51052 - nikomatsakis:obsolete-arrow, r=petrochenkov

1594c6c

restore emplacement syntax (obsolete) Fix #50832 r? @petrochenkov

bors merged commit 626818f into rust-lang:master May 26, 2018

emilyalbini mentioned this pull request May 26, 2018

[beta] Process backports #51037

Merged

emilyalbini added a commit to emilyalbini/rust that referenced this pull request May 28, 2018

Fix build backporting rust-lang#51052

79a12d2

mati865 mentioned this pull request May 29, 2018

Update to nightly 2018-05-28 rust-lang/rust-clippy#2817

Merged

oli-obk added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels May 31, 2018

emilyalbini added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 3, 2018

emilyalbini added a commit to emilyalbini/rust that referenced this pull request Jun 3, 2018

Fix build backporting rust-lang#51052

561310c

emilyalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

restore emplacement syntax (obsolete)#51052

restore emplacement syntax (obsolete)#51052
bors merged 2 commits intorust-lang:masterfrom
nikomatsakis:obsolete-arrow

nikomatsakis commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

petrochenkov May 24, 2018

Uh oh!

nikomatsakis May 25, 2018

Uh oh!

petrochenkov May 24, 2018

Uh oh!

petrochenkov commented May 24, 2018

Uh oh!

nikomatsakis commented May 25, 2018

Uh oh!

bors commented May 25, 2018

Uh oh!

emilyalbini commented May 26, 2018

Uh oh!

bors commented May 26, 2018

Uh oh!

bors commented May 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

nikomatsakis commented May 24, 2018

Uh oh!

rust-highfive commented May 24, 2018

Uh oh!

petrochenkov May 24, 2018

Choose a reason for hiding this comment

Uh oh!

nikomatsakis May 25, 2018

Choose a reason for hiding this comment

Uh oh!

petrochenkov May 24, 2018

Choose a reason for hiding this comment

Uh oh!

petrochenkov commented May 24, 2018

Uh oh!

nikomatsakis commented May 25, 2018

Uh oh!

bors commented May 25, 2018

Uh oh!

emilyalbini commented May 26, 2018

Uh oh!

bors commented May 26, 2018

Uh oh!

bors commented May 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants