Fix self referential impl Trait substitutions#50694
Merged
bors merged 1 commit intorust-lang:masterfrom May 14, 2018
Merged
Conversation
A high impact bug because a lot of common traits use a `Self` substitution by default. Should be backported to beta. There was a check for this which wasn't catching all cases, it was made more robust. Fixes rust-lang#49376 Fixes rust-lang#50626 r? @petrochenkov
Contributor
|
Thanks! |
Collaborator
|
📌 Commit 56bc4c2 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
May 14, 2018
…r=petrochenkov Fix self referential impl Trait substitutions A high impact bug because a lot of common traits use a `Self` substitution by default. Should be backported to beta. There was a check for this which wasn't catching all cases, it was made more robust. Fixes #49376 Fixes #50626 r? @petrochenkov
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Member
|
@leodasvacas proposed to backport this in #50737. @rust-lang/compiler? |
Contributor
Author
|
Justification for backport: Previously |
bors
added a commit
that referenced
this pull request
May 15, 2018
[beta] Process backports Merged on master: * #50648: Fix volatile_store and nontemporal_store * #50735: rustc: don't trip an assertion for enums with present but uninhabited variants. * #50693: typeck: Save the index of private fields * #50748: Update stdsimd module * #50694: Fix self referential impl Trait substitutions r? @alexcrichton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A high impact bug because a lot of common traits use a
Selfsubstitution by default. Should be backported to beta.There was a check for this which wasn't catching all cases, it was made more robust.
Fixes #49376
Fixes #50626
r? @petrochenkov