Merged
Conversation
f33e31e to
ac0f99c
Compare
| "union", | ||
| "foreigntype"]; | ||
|
|
||
| var search_input = document.getElementsByClassName('search-input')[0]; |
Contributor
There was a problem hiding this comment.
I think i'm a little fuzzy on JS's scoping/object rules. Does this automatically get updated if someone types in a search, deletes it, then searches for something else? Having everything reference this variable here seems a little off, but my intuition is based around Rust's rules, not JavaScript's. >_>
Member
Author
There was a problem hiding this comment.
Consider it the same as a reference (or a view). You point to an element but you get the accurate information when you access its fields.
Contributor
There was a problem hiding this comment.
Makes sense, thanks! C# has a similar system for what they call "reference types".
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit ac0f99c has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 26, 2018
…uietMisdreavus Js improvements r? @QuietMisdreavus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @QuietMisdreavus