Conversation
QuietMisdreavus
left a comment
There was a problem hiding this comment.
Yay! The basic design looks good, but there are a couple things that i'd like to see differently.
src/librustdoc/clean/mod.rs
Outdated
There was a problem hiding this comment.
We don't link to the stable std docs anywhere, since libstd itself has a doc_html_root set to the nightly docs. I would prefer if you could somehow grab the url root for std to combine with the "hand-made" primitive link, or at least always link to nightly.
src/librustdoc/clean/mod.rs
Outdated
There was a problem hiding this comment.
If these listings are supposed to be related to each other, can you at least make it a &[(&str, Def)]? A map of some kind would be best, but since it's a const, the slice-of-tuples will work.
74426f7 to
039d291
Compare
039d291 to
561e8ef
Compare
|
Updated. |
|
Looks great! Thanks for getting into this! @bors r+ |
|
📌 Commit 561e8ef has been approved by |
…isdreavus Add primitive intra-links Part of #43466. r? @QuietMisdreavus
|
☀️ Test successful - status-appveyor, status-travis |
Part of #43466.
r? @QuietMisdreavus