Skip to content

address some FIXME whose associated issues were marked as closed#49117

Merged
alexcrichton merged 15 commits intorust-lang:masterfrom
nivkner:fixme_fixup3
Mar 22, 2018
Merged

address some FIXME whose associated issues were marked as closed#49117
alexcrichton merged 15 commits intorust-lang:masterfrom
nivkner:fixme_fixup3

Conversation

@nivkner
Copy link
Contributor

@nivkner nivkner commented Mar 17, 2018

part of #44366

nivkner added 14 commits March 17, 2018 20:24
@nivkner
update FIXME(rust-lang#6393) to point to issue 43234 (tracking issue …
7278e37 
…for non-lexical lifetimes)
@nivkner
update FIXME(rust-lang#15760) to point to issue 27336 (tracking issue…
ba836f4 
… for Default Type Parameter Fallback)
@nivkner
update FIXME(rust-lang#7622) to point to issue 44580 (tracking issue …
d1dacdd 
…for const generics)
@nivkner
update FIXME(rust-lang#23442) to point to issue 45742 (Blanket impl o…
e1b9bf0 
…f AsRef for Deref)
@nivkner
update FIXME(rust-lang#5244) to point to RFC 1109 (Non-Copy array cre…
3753e1a 
…ation ergonomics)
@nivkner
remove FIXME(rust-lang#39119) and allow running test on emscripten
4a06708
@nivkner
remove FIXME(rust-lang#37712) and implement ItemLikeVisitor instead o…
622c445 
…f Visitor
@nivkner
remove FIXME(rust-lang#30046) and infer moves on pattern matching
69d12a2
@nivkner
remove FIXME(rust-lang#11094) and allow make tests to run on targets …
fd00755 
…besides host
@nivkner
remove FIXME(rust-lang#2543) and avoid bad copies
2c6b7b9
@nivkner
remove FIXME(rust-lang#48116) and remove the logic to debug the issue
0d8fa82
@nivkner
remove FIXME(rust-lang#33435) and remove the spurious failures counte…
be73a1f 
…r measure
@nivkner
remove FIXME(rust-lang#8372) since for-loops wont support borrowing i…
c8be5c3 
…terators
@nivkner
remove FIXME(rust-lang#27889) since the issue is already fixed
d5b55c1
@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 17, 2018

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @michaelwoerister (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 17, 2018
@michaelwoerister
Copy link
Member

michaelwoerister commented Mar 19, 2018

Thanks for the PR, @nivkner! I'll review as soon as I find the time (unless someone else from @rust-lang/compiler beats me to it).

estebank
estebank reviewed Mar 20, 2018
View reviewed changes
src/tools/compiletest/src/main.rs
_ => { /* proceed */ }
}

// FIXME(#33435) Avoid spurious failures in codegen-units/partitioning tests.
Copy link
Contributor

@estebank estebank Mar 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only removal that gives me pause, the rest LGTM.

Copy link
Contributor Author

@nivkner nivkner Mar 21, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the issue again. This was the fix mentioned, so reverting commit.

@estebank
Copy link
Contributor

estebank commented Mar 21, 2018

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 21, 2018

📌 Commit 66d120c has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 21, 2018
@kennytm kennytm mentioned this pull request Mar 21, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Mar 21, 2018
@kennytm
Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank
c90871c 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
@kennytm kennytm mentioned this pull request Mar 22, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Mar 22, 2018
@kennytm
Rollup merge of rust-lang#49117 - nivkner:fixme_fixup3, r=estebank
8d3f3f0 
address some FIXME whose associated issues were marked as closed

part of rust-lang#44366
bors added a commit that referenced this pull request Mar 22, 2018
@bors
Auto merge of #49264 - kennytm:rollup, r=kennytm
5092c6b 
Rollup of 23 pull requests

- Successful merges: #48374, #48596, #48759, #48939, #49029, #49069, #49093, #49109, #49117, #49140, #49158, #49188, #49189, #49209, #49211, #49216, #49225, #49231, #49234, #49242, #49244, #49105, #49038
- Failed merges:
@alexcrichton alexcrichton merged commit 66d120c into rust-lang:master Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebank estebank estebank left review comments

Assignees

@michaelwoerister michaelwoerister

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nivkner @rust-highfive @michaelwoerister @estebank @bors @alexcrichton