Merged
Conversation
Member
|
What is the tradeoff here? That we won't clean out submodules if they have untracked files? |
Contributor
Author
|
Yeah, they won't get cleaned by default, only when the submodule commit is outdated and the submodule updates. |
Member
|
That seems fine to me. I'm generally okay with this change then. |
Member
|
@bors: r+ rollup Nice! |
Collaborator
|
📌 Commit 72cb109 has been approved by |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Mar 17, 2018
Faster submodule updating For the common case when there are no submodules which need updating, this takes 0.48 seconds instead of 47 seconds. r? @alexcrichton
bors
added a commit
that referenced
this pull request
Mar 17, 2018
Contributor
|
I’m late to the party, but another reason to support this change: I was once surprised (and annoyed) to see the build system silently erase uncommitted local changes that I had just made to a submodule. Fortunately I still had those files open in my text editor, but silent data loss is really not good. |
Contributor
Author
|
@SimonSapin That can still happen though if you pull master and the submodule was updated. |
jyn514
added a commit
to jyn514/rust
that referenced
this pull request
May 24, 2022
I don't know why anyone would turn this off; doing so makes builds much slower (nearly a 60x slowdown according to rust-lang#49057). Remove the option to do so, which makes bootstrap a little easier to maintain. Bootstrap continues to allow you to manage submodules manually by setting `submodules = false`.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 24, 2022
…lacrum Turn on `fast_submodules` unconditionally I don't know why anyone would turn this off; doing so makes builds much slower (nearly a 60x slowdown according to rust-lang#49057). Remove the option to do so, which makes bootstrap a little easier to maintain. Bootstrap continues to allow you to manage submodules manually by setting `submodules = false`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the common case when there are no submodules which need updating, this takes 0.48 seconds instead of 47 seconds.
r? @alexcrichton