incr.comp.: Cache type_of and some other queries.#47455
incr.comp.: Cache type_of and some other queries.#47455bors merged 3 commits intorust-lang:masterfrom
Conversation
|
@bors r+ |
|
📌 Commit b726204 has been approved by |
say a bit more about this? is this a bug to be closed? |
|
The incr.comp. cache serializer does not accept raw DefIndex values because it cannot make sense of them without the corresponding CrateNum. I plan to fix this by creating a special data structure with custom serialization for this lookup table (or I'll open an issue with mentoring instruction). It's not a really bug though because we have an assertion against accidentally running into trouble there. |
…r=nikomatsakis incr.comp.: Cache type_of and some other queries. Cache some more queries that show up high during profiling. Does not include `generics_of` yet (which profiling shows to also take up quite some time) because the `type_param_to_index` field in there uses raw `DefIndex` values from other crates. r? @nikomatsakis
|
@nikomatsakis, I pushed two more commits to also cache the @kennytm, I hope this doesn't mess with your rollup. |
well, the "bug" is probably just not using |
|
I switched it to regular |
|
@bors r+ |
|
📌 Commit 0f13dbd has been approved by |
|
☔ The latest upstream changes (presumably #47373) made this pull request unmergeable. Please resolve the merge conflicts. |
0f13dbd to
0a4f347
Compare
|
@bors r+ (@michaelwoerister -- did you forget this?) |
|
📌 Commit 0a4f347 has been approved by |
Cache some more queries that show up high during profiling. Does not include
generics_ofyet (which profiling shows to also take up quite some time) because thetype_param_to_indexfield in there uses rawDefIndexvalues from other crates.r? @nikomatsakis