Speedup search loading when search url is received#46221
Speedup search loading when search url is received#46221bors merged 1 commit intorust-lang:masterfrom
Conversation
nrc
left a comment
There was a problem hiding this comment.
This seems like an improvement since we won't see the 'main' page, but it doesn't seem like it will actually speed anything up. Questions:
- would it actually be possible to get the search results quicker, or is this as good as it gets?
- would it make any difference if we didn't download the 'main' page, rather than just not show it? Is that even possible to do?
So r+ for this, but curious if we can do better too.
To get results faster, we need the search to be faster. Other (opened) PRs of mine are improving this. However, there's no magic in here and unfortunately, I don't think we'll be able to be this much faster...
What is the 'main' page you're referring to? If you're talking about the docs, we cannot not have it. |
|
Triage — Hi @nrc, is @GuillaumeGomez's answers in #46221 (comment) satisfactory for r+? |
|
@nrc Ping for review again (on #rust-internals as well)! |
|
@bors: r+ |
|
📌 Commit de3a291 has been approved by |
|
@bors rollup |
|
☀️ Test successful - status-appveyor, status-travis |
Fixes #45971.
r? @nrc
cc @rust-lang/docs