Merged
Conversation
This much simpler implementation uses a global mutex and eliminates the kernel environment channel.
Contributor
Author
|
Oh, this also sneaks in my try/finally library, described here, though it's hidden under the |
Contributor
|
Fantastic. r+ with 100 +s |
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Oct 13, 2025
readme: document how to directly invoke the driver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @graydon
This branch removes most uses of oldcomm. It isn't quite ready but I've been at it for a while so I'm posting it for review. Removing the last few usages of oldcomm from std is proving to be time consuming because there's a lot of tricky unsafe code involved. This also won't be mergable until I figure out #4478.
The general strategy:
at_exitfacility where the runtime will execute a closure just before shutdown.at_exitfor cleanup.chan_from_global_ptrto the new interfaceschan_from_global_ptrfunctionsOrganizationally, this dumps all the new modules under
core::private, which I recognize is not right. I intend to reorganize the runtime code as outlined in #2240.