add ABIInfo trait and separate x86-64 ABI implementation from foreign trans#4590
add ABIInfo trait and separate x86-64 ABI implementation from foreign trans#4590catamorphism merged 1 commit intorust-lang:incomingfrom
Conversation
|
Sorry, but can you rebase this against the latest incoming and re-submit? |
|
Very cool. I'm glad to see this refactoring. |
… trans ABIInfo provides a method to translate the type of foreign function. The foreign trans uses the method to get ABI-specific type and uses the result to generate LLVM instructions for wrapper and shim functions.
|
I rebased and pushed. |
add ABIInfo trait and separate x86-64 ABI implementation from foreign trans
|
Thanks! |
|
Sorry, I had to revert this because it broke the Windows build. One of us will un-revert once we figure out what's going on. |
|
Thanks for the quick backout. Sorry for the abrupt comment -- was on a cell phone. Just trying to get an all-green to snapshot. |
|
No worries, a snapshot will be amazing! |
|
@crabtw - Do you have access to a Windows machine? This patch is still failing on Windows: http://buildbot.rust-lang.org/builders/try-win/builds/210/steps/compile/logs/stdio -- and I don't really know where to start as to figuring out why. |
|
@catamorphism Sorry, I have no Windows machine. https://github.com/mozilla/rust/pull/4590/files#L0R166 is the problem. Replacing the condition with |
|
@crabtw Ok, thanks -- I tried making that change and am running try. |
Automatic Rustup
ABIInfo provides a method to translate the type of foreign function.
The foreign trans uses the method to get ABI-specific type and uses the result to generate LLVM instructions for wrapper and shim functions.