Skip to content

Add x86_64-unknown-linux-gnux32 target#45224

Merged
bors merged 6 commits intorust-lang:masterfrom
malbarbo:x32
Oct 15, 2017
Merged

Add x86_64-unknown-linux-gnux32 target#45224
bors merged 6 commits intorust-lang:masterfrom
malbarbo:x32

Conversation

@malbarbo
Copy link
Contributor

@malbarbo malbarbo commented Oct 12, 2017

This adds X32 ABI support for Linux on X86_64. Let's package and dist it so we can star testing libc, libstd, etc.

Fixes rust-lang/rfcs#1339

@rust-highfive
Copy link
Contributor

rust-highfive commented Oct 12, 2017

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

@malbarbo malbarbo mentioned this pull request Oct 12, 2017
Closed
@malbarbo
Copy link
Contributor Author

malbarbo commented Oct 12, 2017

Add the target build to cross2 because it seems to have some free time.

@malbarbo
Copy link
Contributor Author

malbarbo commented Oct 12, 2017

Why this target is important?

Compared to amd64, x32 offers significant memory savings, often on the order of 30%, and modest efficiency gains.

Compared to i386, there's no memory use difference, but speed increases are more pronounced, especially in code that's under register pressure, operates on 64-bit or floating-point variables. It also avoids i386's penalty for PIC code, where EBX is essentially reserved for the Global Offset Table (GOT).

There are three principal use cases:

  • vserver hosting (memory bound)
  • netbooks/tablets (low memory, want performance)
  • scientific tasks (want every % of performance)

From Debian X32 port.

@malbarbo
Copy link
Contributor Author

malbarbo commented Oct 12, 2017

r? @alexcrichton

@alexcrichton
Copy link
Member

alexcrichton commented Oct 12, 2017

@bors: r+

Thanks!

@bors
Copy link
Collaborator

bors commented Oct 12, 2017

📌 Commit 7199fee has been approved by alexcrichton

@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 13, 2017
@bors
Copy link
Collaborator

bors commented Oct 15, 2017

⌛ Testing commit 7199fee with merge 6c0d50f...

bors added a commit that referenced this pull request Oct 15, 2017
@bors
Auto merge of #45224 - malbarbo:x32, r=alexcrichton
6c0d50f 
Add x86_64-unknown-linux-gnux32 target

This adds X32 ABI support for Linux on X86_64. Let's package and dist it so we can star testing libc, libstd, etc.

Fixes rust-lang/rfcs#1339
@bors
Copy link
Collaborator

bors commented Oct 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 6c0d50f to master...

@bors bors merged commit 7199fee into rust-lang:master Oct 15, 2017
This was referenced Oct 15, 2017
Merged
Merged
@malbarbo malbarbo mentioned this pull request Oct 19, 2017
Closed
@malbarbo malbarbo deleted the x32 branch October 25, 2017 16:38
@davidtwco davidtwco mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malbarbo @rust-highfive @alexcrichton @bors @kennytm @arielb1