Conversation
|
cc #44229 |
ollie27
left a comment
There was a problem hiding this comment.
Apart from that one error this looks good to me.
src/librustdoc/html/render.rs
Outdated
There was a problem hiding this comment.
This should be 45 to make sure the resulting string is at most 70 characters.
There was a problem hiding this comment.
Addressed this, thanks! I set to 50 (as in the old code), there is no strict need to be under 70 chars, it is just roughly a number that should fit on one line (comfortably under 80 chars).
There was a problem hiding this comment.
Well that's okay but if the line is exactly 71 characters for example then using 50 will skip one character and replace it with " ... " making the string display actually longer. It's only a minor thing though.
f0a816d to
0573949
Compare
|
ping @ollie27 for re-review |
|
@bors: r+ |
|
@ollie27: 🔑 Insufficient privileges: Not in reviewers |
|
@bors: r=ollie27 |
|
📌 Commit 0573949 has been approved by |
|
@bors rollup |
Fixup some nits from rust-lang#44238 r? @ollie27
Fixup some nits from rust-lang#44238 r? @ollie27
Fixup some nits from rust-lang#44238 r? @ollie27
r? @ollie27