Pass debugging arguments to emcc#43344
Merged
bors merged 1 commit intorust-lang:masterfrom Jul 22, 2017
Merged
Conversation
Tells emcc to enable assertions and debugging information for wasm32-experimental-emscripten. This makes the codegen issues caused by LLVM bug 33824 manifest more frequently at runtime and improves the wasm debugging experience.
Contributor
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
Member
|
@bors: r+ |
Collaborator
|
📌 Commit 6a3e322 has been approved by |
Collaborator
|
⌛ Testing commit 6a3e322 with merge 8856e751e67b6301c2ad5bb2f7f8f6af80baa54a... |
Collaborator
|
💔 Test failed - status-travis |
Contributor
Hmm, not sure about this one. Sounds like a failure while downloading something? So @bors retry |
Collaborator
|
⌛ Testing commit 6a3e322 with merge 969dd6ac0b7e66f7670005e3035ff5fff3146586... |
Collaborator
|
💔 Test failed - status-appveyor |
Member
|
@bors: retry
|
Collaborator
bors
added a commit
that referenced
this pull request
Jul 22, 2017
Pass debugging arguments to emcc Tells emcc to enable assertions and debugging information for wasm32-experimental-emscripten. This makes the codegen issues caused by LLVM bug 33824 manifest more frequently at runtime and improves the wasm debugging experience.
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tells emcc to enable assertions and debugging information for
wasm32-experimental-emscripten. This makes the codegen issues caused by
LLVM bug 33824 manifest more frequently at runtime and improves the wasm
debugging experience.