Skip to content

Saves created temp directory if save-temps option is used.#42864

Merged
bors merged 1 commit intorust-lang:masterfrom
slo1:attempt
Jun 24, 2017
Merged

Saves created temp directory if save-temps option is used.#42864
bors merged 1 commit intorust-lang:masterfrom
slo1:attempt

Conversation

@slo1
Copy link
Contributor

@slo1 slo1 commented Jun 23, 2017

Should fix #38068.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 23, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster
Copy link
Member

shepmaster commented Jun 23, 2017

Thanks @slo1! We'll get @nikomatsakis or another highly qualified reviewer to check this out soon!

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2017
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 23, 2017

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 23, 2017

📌 Commit a5c29cb has been approved by Mark-Simulacrum

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2017
@bors
Copy link
Collaborator

bors commented Jun 24, 2017

⌛ Testing commit a5c29cb with merge c9bb935...

bors added a commit that referenced this pull request Jun 24, 2017
@bors
Auto merge of #42864 - slo1:attempt, r=Mark-Simulacrum
c9bb935 
Saves created temp directory if save-temps option is used.

Should fix #38068.
@bors
Copy link
Collaborator

bors commented Jun 24, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: Mark-Simulacrum
Pushing c9bb935 to master...

@bors bors merged commit a5c29cb into rust-lang:master Jun 24, 2017
@slo1 slo1 deleted the attempt branch June 24, 2017 17:11
@infinity0 infinity0 mentioned this pull request Aug 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

temp dir rustc.* is deleted even when -C save-temps applys

6 participants

@slo1 @rust-highfive @shepmaster @Mark-Simulacrum @bors @nikomatsakis