Skip to content

Add tests for various issues#42734

Merged
bors merged 1 commit intorust-lang:masterfrom
MaloJaffre:tests
Jun 18, 2017
Merged

Add tests for various issues#42734
bors merged 1 commit intorust-lang:masterfrom
MaloJaffre:tests

Conversation

@MaloJaffre
Copy link
Contributor

@MaloJaffre MaloJaffre commented Jun 18, 2017 •
edited
Loading

Fixes #11740.
Fixes #19601.
Fixes #22603
Fixes #22789.
Fixes #26614.

r? @Mark-Simulacrum.

@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 18, 2017

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Mark-Simulacrum
Mark-Simulacrum requested changes Jun 18, 2017
View reviewed changes
src/test/compile-fail/issue-11740.rs Outdated
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Jun 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix up the copyright dates to 2017? I don't know if it matters, but it seems wrong to back-date copyrights.

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 18, 2017

r=me aside from the copyright dates, thanks!

@bors rollup

@MaloJaffre
Copy link
Contributor Author

MaloJaffre commented Jun 18, 2017 •
edited
Loading

Fixed, thanks for the review @Mark-Simulacrum!

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 18, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 18, 2017

📌 Commit 5fe89e8 has been approved by Mark-Simulacrum

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jun 18, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#42734 - MaloJaffre:tests, r=Mark-Simulacrum
3bed3bd 
Add tests for various issues

Fixes rust-lang#11740.
Fixes rust-lang#19601.
Fixes rust-lang#22603
Fixes rust-lang#22789.
Fixes rust-lang#26614.

r? @Mark-Simulacrum.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Jun 18, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 18, 2017
@frewsxcv
Rollup merge of rust-lang#42734 - MaloJaffre:tests, r=Mark-Simulacrum
bfdbfca 
Add tests for various issues

Fixes rust-lang#11740.
Fixes rust-lang#19601.
Fixes rust-lang#22603
Fixes rust-lang#22789.
Fixes rust-lang#26614.

r? @Mark-Simulacrum.
@frewsxcv frewsxcv mentioned this pull request Jun 18, 2017
Closed
bors added a commit that referenced this pull request Jun 18, 2017
@bors
Auto merge of #42738 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
247a018 
Rollup of 7 pull requests

- Successful merges: #42695, #42714, #42720, #42723, #42730, #42731, #42734
- Failed merges: #42722
@bors bors merged commit 5fe89e8 into rust-lang:master Jun 18, 2017
@MaloJaffre MaloJaffre deleted the tests branch June 18, 2017 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MaloJaffre @rust-highfive @Mark-Simulacrum @bors