Possible mistake in lexer rule for octal integer#42638
Possible mistake in lexer rule for octal integer#42638bors merged 1 commit intorust-lang:masterfrom arthrarnld:lexer_rule_for_octal
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@arthurpaimarnold @bors r+ rollup |
|
📌 Commit c291e87 has been approved by |
|
@petrochenkov, I wasn't aware of that. Could you point me to the actual lexer? :) |
|
@arthurpaimarnold It's in src/libsyntax/parse/lexer/mod.rs |
…al, r=petrochenkov Possible mistake in lexer rule for octal integer Original rule allowed for digits 0-8, but octal is 0-7. The compiler correctly prevents you from placing an 8 in an octal, so I'm assuming this is caught on a later stage. Still, shouldn't the lexer already catch this?
Original rule allowed for digits 0-8, but octal is 0-7.
The compiler correctly prevents you from placing an 8 in an octal, so I'm assuming this is caught on a later stage. Still, shouldn't the lexer already catch this?