Upgrade ProjectionTy's Name to a DefId by tbg · Pull Request #42297 · rust-lang/rust

tbg · 2017-05-29T15:11:46Z

Part of #42171, in preparation for downgrading the contained TraitRef to
only its substs.

Some inline questions in the diff. Look for FIXME(tschottdorf). These comments
should be addressed before merging.

rust-highfive · 2017-05-29T15:11:58Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

nikomatsakis

This looks pretty good. I left a few requests for changes. The main question is whether we care about hygiene for these item lookups (as you noted) -- I would guess no, but perhaps @jseyfried or @petrochenkov knows better?

nikomatsakis · 2017-05-30T20:21:13Z

src/librustc/ty/structural_impls.rs

this is correct as is

nikomatsakis · 2017-05-30T20:21:57Z

src/librustc/ty/sty.rs

I would say "The DefId of the TraitItem for the associated type N."

PS kudos to you for commenting :)

nikomatsakis · 2017-05-30T20:22:43Z

src/librustc/ty/sty.rs

Nit: formatting. I think that in this case, the -> goes on next line, and I personally would put { indented with pub (so that body is clearly distinguished from the signature). But we don't have hard-and-fast rules here. You could also align with the open (.

Done (I think?)

nikomatsakis · 2017-05-30T20:23:25Z

src/librustc/ty/sty.rs

Yeah, bother, I don't know how hygiene and "associated item lookup" are supposed to interact here. @jseyfried may have thoughts.

Removed as per comment on main thread.

nikomatsakis · 2017-05-30T20:25:10Z

src/librustc/ty/sty.rs

Maybe add a comment here?

"Construct a ProjectionTy by searching the trait from trait_ref for the associated item named item_name."

nikomatsakis · 2017-05-30T20:26:03Z

src/librustc/ty/util.rs

we don't actually need the first hash (of data.trait_ref.def_id); the second should suffice, I think.

nikomatsakis · 2017-05-30T20:27:03Z

src/librustc_typeck/check/autoderef.rs

this is fine for now; eventually, though, we could make lang-items for the associated types from "well known" traits like this

Ack, feel free to throw that my way at some point. I'm not sure what it would entail.

nikomatsakis · 2017-05-30T21:11:26Z

@arielb1 writes on IRC that we don't use hygiene for associated item lookup at present (which is also what I thought). This suggests @tschottdorf that the code for ProjectionTy::from_trait_ref_and_name() is fine just as you have it, and you can remove that comment.

Part of rust-lang#42171, in preparation for downgrading the contained `TraitRef` to only its `substs`.

tbg · 2017-05-31T16:35:29Z

Thanks for the review! Comments addressed.

nikomatsakis · 2017-05-31T21:25:35Z

@bors r+

bors · 2017-05-31T21:25:37Z

📌 Commit e5e664f has been approved by nikomatsakis

Upgrade ProjectionTy's Name to a DefId Part of rust-lang#42171, in preparation for downgrading the contained `TraitRef` to only its `substs`. Some inline questions in the diff. Look for `FIXME(tschottdorf)`. These comments should be addressed before merging.

Rollup of 9 pull requests - Successful merges: #42136, #42275, #42286, #42297, #42302, #42306, #42314, #42324, #42347 - Failed merges:

rust-highfive assigned nikomatsakis May 29, 2017

Mark-Simulacrum added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2017

tbg force-pushed the proj-ty branch from 18b6154 to 7702c4a Compare May 30, 2017 01:07

nikomatsakis requested changes May 30, 2017

View reviewed changes

tbg force-pushed the proj-ty branch from 7702c4a to 2d74471 Compare May 31, 2017 16:32

Upgrade ProjectionTy's Name to a DefId

e5e664f

Part of rust-lang#42171, in preparation for downgrading the contained `TraitRef` to only its `substs`.

tbg force-pushed the proj-ty branch from 2d74471 to e5e664f Compare May 31, 2017 16:35

nikomatsakis approved these changes May 31, 2017

View reviewed changes

nikomatsakis mentioned this pull request May 31, 2017

[RFC] Refactor types to be a (TypeCore, Substs) pair #42340

Closed

4 tasks

Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2017

frewsxcv mentioned this pull request Jun 1, 2017

Rollup of 9 pull requests #42345

Closed

frewsxcv mentioned this pull request Jun 1, 2017

Rollup of 8 pull requests #42346

Closed

frewsxcv mentioned this pull request Jun 1, 2017

Rollup of 9 pull requests #42348

Merged

bors added a commit that referenced this pull request Jun 1, 2017

Auto merge of #42348 - frewsxcv:rollup, r=frewsxcv

38efb2e

Rollup of 9 pull requests - Successful merges: #42136, #42275, #42286, #42297, #42302, #42306, #42314, #42324, #42347 - Failed merges:

bors merged commit e5e664f into rust-lang:master Jun 1, 2017

Uh oh!

Conversation

tbg commented May 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented May 29, 2017

Uh oh!

nikomatsakis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented May 30, 2017

Uh oh!

tbg commented May 31, 2017

Uh oh!

nikomatsakis commented May 31, 2017

Uh oh!

bors commented May 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tbg commented May 29, 2017 •

edited

Loading