Merged
Conversation
The new messages seem universally better. I think these result because we recognize that we are in an invariant context more often.
This seems both to be a safe, conservative choice, and it sidesteps the cycle in rust-lang#41936. Fixes rust-lang#41936.
Fixes rust-lang#41849. Problem was that evaluating the constant expression required evaluating a trait, which would equate types, which would request variance information, which it would then discard. However, computing the variance information would require determining the type of a field, which would evaluate the constant expression. (This problem will potentially arise *later* as we move to more sophisticated constants, however, where we need to check subtyping. We can tackle that when we come to it.)
Contributor
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
|
Contributor
Author
|
@bors r+ p=1 |
Collaborator
|
📌 Commit a30c932 has been approved by |
Collaborator
|
⌛ Testing commit a30c932 with merge adad643... |
Collaborator
|
💔 Test failed - status-travis |
Member
|
Failure in building OpenSSL on macOS.
|
Member
Contributor
|
@bors r+ p=1 I went ahead and backported the simple openssl build fix. |
Collaborator
|
📌 Commit 0566d02 has been approved by |
Collaborator
|
⌛ Testing commit 0566d02 with merge 2df18ed... |
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports of: