Make trans treat all statements as if they introduce a new scope#4192
Closed
catamorphism wants to merge 1 commit intorust-lang:incomingfrom
Closed
Make trans treat all statements as if they introduce a new scope#4192catamorphism wants to merge 1 commit intorust-lang:incomingfrom
catamorphism wants to merge 1 commit intorust-lang:incomingfrom
Conversation
This is for consistency with borrowck. Changing borrowck would also be an alternative, but I found it easier to change trans :-) This eliminates an ICE in trans where the scope for a particular borrow was a statement ID, but the code in trans that does cleanups wasn't finding the block with that scope. As per rust-lang#3860
Contributor
|
r+ with a couple caveats:
Sorry, this stuff is delicate-city and I know we're likely to revisit it. Best to lay down invariant-describing docs as we go. |
Contributor
Author
|
Contributor
Author
|
|
Contributor
Author
|
I'm going to close this since it's pretty clearly not the right solution. The bug is still open. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 15, 2020
…flip1995 Reversed empty ranges This lint checks range expressions with inverted limits which result in empty ranges. This includes also the ranges used to index slices. The lint reverse_range_loop was covering iteration of reversed ranges in a for loop, which is a subset of what this new lint covers, so it has been removed. I'm not sure if that's the best choice. It would be doable to check in the new lint that we are not in the arguments of a for loop; I went for removing it because the logic was too similar to keep them separated. changelog: Added reversed_empty_ranges lint that checks for ranges where the limits have been inverted, resulting in empty ranges. Removed reverse_range_loop which was covering a subset of the new lint. Closes rust-lang#4192 Closes rust-lang#96
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Feb 24, 2025
Remove the build script for miri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @graydon This is for consistency with borrowck. Changing borrowck would
also be an alternative, but I found it easier to change trans :-)
This eliminates an ICE in trans where the scope for a particular
borrow was a statement ID, but the code in trans that does cleanups
wasn't finding the block with that scope. As per #3860