Skip to content

Remove Reflect#39075

Merged
bors merged 1 commit intorust-lang:masterfrom
est31:remove_reflect
Jan 26, 2017
Merged

Remove Reflect#39075
bors merged 1 commit intorust-lang:masterfrom
est31:remove_reflect

Conversation

@est31
Copy link
Member

@est31 est31 commented Jan 15, 2017 •
edited by nikomatsakis
Loading

PR for removing the Reflect trait. Opened so that a crater run can be done for testing the impact: #27749 (comment)

Fixes #27749

@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 15, 2017

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@est31
Copy link
Member Author

est31 commented Jan 15, 2017

I'm not 100% sure of the comment change in src/librustc/traits/select.rs (and generally I don't have much knowledge of the code involved, but the change seemed pretty straightforward). Correct me if I'm wrong.

@est31 est31 mentioned this pull request Jan 15, 2017
Closed
@bors
Copy link
Collaborator

bors commented Jan 16, 2017

☔ The latest upstream changes (presumably #39071) made this pull request unmergeable. Please resolve the merge conflicts.

@est31
Copy link
Member Author

est31 commented Jan 16, 2017

Rebased.

@bors
Copy link
Collaborator

bors commented Jan 22, 2017

☔ The latest upstream changes (presumably #39243) made this pull request unmergeable. Please resolve the merge conflicts.

@est31
Copy link
Member Author

est31 commented Jan 22, 2017

@nikomatsakis you said that you've started a crater run on this PR. Are there any results in yet? Also, will me rebasing this PR in any way inconvenience the crater run? I don't want to force-push and destroy something :)

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 24, 2017

@est31 let me check :) also, rebase away

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 24, 2017

@est31 something went wrong with my run :(

@est31
Remove Reflect
af46d69 
* Remove the Reflect trait
* Remove the "reflect" lang feature
@est31
Copy link
Member Author

est31 commented Jan 24, 2017

@nikomatsakis rebased.

@brson
Copy link
Contributor

brson commented Jan 24, 2017

I will crater it.

@brson
Copy link
Contributor

brson commented Jan 25, 2017

Crater says.

@pnkfelix
Copy link
Contributor

pnkfelix commented Jan 25, 2017

the three root regressions reported by crater all are pretty obvious (each crate is importing Reflect and so the compiler complains).

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 25, 2017

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 25, 2017

📌 Commit af46d69 has been approved by nikomatsakis

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Jan 25, 2017

The feature is deprecated and removal is the plan, and the PR looks good; impact is minimal. So I gave r+!

@bors
Copy link
Collaborator

bors commented Jan 26, 2017

⌛ Testing commit af46d69 with merge 5158501...

bors added a commit that referenced this pull request Jan 26, 2017
@bors
Auto merge of #39075 - est31:remove_reflect, r=nikomatsakis
5158501 
Remove Reflect

PR for removing the `Reflect` trait. Opened so that a crater run can be done for testing the impact: #27749 (comment)

Fixes #27749
@bors
Copy link
Collaborator

bors commented Jan 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 5158501 to master...

@bors bors merged commit af46d69 into rust-lang:master Jan 26, 2017
@bors bors mentioned this pull request Jan 26, 2017
Merged
@est31 est31 mentioned this pull request Jan 26, 2017
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pnkfelix pnkfelix

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@est31 @rust-highfive @bors @nikomatsakis @brson @pnkfelix