Remove unneeded tricky macro doc#37870
Closed
GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Closed
Remove unneeded tricky macro doc#37870GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
GuillaumeGomez wants to merge 1 commit intorust-lang:masterfrom
Conversation
Member
|
You sure? This isn't used by libstd docs, but have you checked libcore docs? |
Member
Author
|
It's no longer in libcore docs for sure. I'll just remove the |
Contributor
|
Do these changes result in #36272 becoming an issue again? |
Contributor
|
Relevant PR #37325 |
Member
|
I don't want to cause #36272 again. |
Member
Author
|
cc @eddyb |
bors
added a commit
that referenced
this pull request
Nov 30, 2016
rustdoc: link to cross-crate sources directly. Fixes #37684 by implementing proper support for getting the `Span` of definitions across crates. In rustdoc this is used to generate direct links to the original source instead of fragile redirects. This functionality could be expanded further for making error reporting code more uniform and seamless across crates, although at the moment there is no actual source to print, only file/line/column information. Closes #37870 which is also "fixes" #37684 by throwing away the builtin macro docs from libcore. After this lands, #37727 could be reverted, although it doesn't matter much either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37684.
Macros are still linked in the docs so I'm sure why such thing existed in the first place...
r? @eddyb