Merged
Conversation
nagisa
reviewed
Oct 3, 2016
| "non-exhaustive patterns: type {} is non-empty", | ||
| pat_ty); | ||
| let mut err = create_e0004(cx.tcx.sess, ex.span, | ||
| format!("non-exhaustive patterns: type {} \ |
Member
There was a problem hiding this comment.
So now instead of having just two error codes we do allocations instead?
Member
Author
There was a problem hiding this comment.
If you see another solution, I'm totally looking forward to it. :-/
Contributor
|
Pinging @arielb1 - what did you have in mind for the refactor for E0002 and E0004? |
Contributor
|
That kind of thing. |
Member
Author
|
Then we're all good! :D |
Contributor
|
@bors r+ rollup |
Collaborator
|
📌 Commit cb22364 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Oct 6, 2016
…=arielb1 Merge E0002 into E0004 Fixes rust-lang#36724. r? @jonathandturner
bors
added a commit
that referenced
this pull request
Oct 6, 2016
jfirebaugh
added a commit
to jfirebaugh/rust
that referenced
this pull request
Oct 9, 2016
E0002 was merged into E0004 in rust-lang#36909, and the long diagnostic for E0004 is sufficient to cover empty match expressions.
This was referenced Oct 9, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36724.
r? @jonathandturner