Skip to content

fixed the safety header/wording in option.rs#36589

Merged
bors merged 1 commit intorust-lang:masterfrom
jpadkins:option_docs_safety_wording_fix
Sep 22, 2016
Merged

fixed the safety header/wording in option.rs#36589
bors merged 1 commit intorust-lang:masterfrom
jpadkins:option_docs_safety_wording_fix

Conversation

@jpadkins
Copy link

@jpadkins jpadkins commented Sep 19, 2016

Fixes #36581

screenshot of the rendered documentation: http://imgur.com/14kLVrA

r? @steveklabnik

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 19, 2016

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bluss
Copy link
Contributor

bluss commented Sep 20, 2016

Thank you!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 20, 2016

📌 Commit 8b02aa1 has been approved by bluss

@steveklabnik
Copy link
Contributor

steveklabnik commented Sep 21, 2016

Perfect. Sorry for the latency @jpadkins , but this is great!

@bluss
Copy link
Contributor

bluss commented Sep 21, 2016

@steveklabnik You're faster than bors, at least.

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 21, 2016
Rollup merge of rust-lang#36589 - jpadkins:option_docs_safety_wording…
5cd252c 
…_fix, r=bluss

fixed the safety header/wording in option.rs

Fixes rust-lang#36581

screenshot of the rendered documentation: http://imgur.com/14kLVrA

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Sep 21, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 21, 2016
Rollup merge of rust-lang#36589 - jpadkins:option_docs_safety_wording…
ae315da 
…_fix, r=bluss

fixed the safety header/wording in option.rs

Fixes rust-lang#36581

screenshot of the rendered documentation: http://imgur.com/14kLVrA

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Sep 21, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Sep 22, 2016
Rollup merge of rust-lang#36589 - jpadkins:option_docs_safety_wording…
5d4c0ed 
…_fix, r=bluss

fixed the safety header/wording in option.rs

Fixes rust-lang#36581

screenshot of the rendered documentation: http://imgur.com/14kLVrA

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Sep 22, 2016
Merged
bors added a commit that referenced this pull request Sep 22, 2016
@bors
Auto merge of #36651 - jonathandturner:rollup, r=jonathandturner
4c04e36 
Rollup of 7 pull requests

- Successful merges: #36330, #36423, #36539, #36571, #36589, #36600, #36632
- Failed merges:
@bors bors merged commit 8b02aa1 into rust-lang:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpadkins @rust-highfive @bluss @bors @steveklabnik