Skip to content

fix "X is not a member of trait Y" span labels#36429

Merged
bors merged 1 commit intorust-lang:masterfrom
durka:patch-30
Sep 15, 2016
Merged

fix "X is not a member of trait Y" span labels#36429
bors merged 1 commit intorust-lang:masterfrom
durka:patch-30

Conversation

@durka
Copy link
Contributor

@durka durka commented Sep 12, 2016

Fixes #36428.

@rust-highfive
Copy link
Contributor

rust-highfive commented Sep 12, 2016

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

GuillaumeGomez
GuillaumeGomez reviewed Sep 12, 2016
View reviewed changes
src/librustc_resolve/lib.rs Outdated
Copy link
Member

@GuillaumeGomez GuillaumeGomez Sep 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing "trait"? I actually find this better with it.

@durka
fix "X is not a member of trait Y" span labels
0a62676 
The span labels for associated types and consts were hardcoded to `Foo`
rather than substituting the name of the trait.

This also normalizes the wording for associated methods', traits', and
consts' span labels.

Fixes rust-lang#36428.
@durka durka changed the title fix span label for trait nonmember error fix "X is not a member of trait Y" span labels Sep 13, 2016
@durka
Copy link
Contributor Author

durka commented Sep 13, 2016

Travis passed, so I squashed the commits.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Sep 13, 2016

All good for me!

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Sep 13, 2016

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Sep 13, 2016

📌 Commit 0a62676 has been approved by nagisa

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

⌛ Testing commit 0a62676 with merge e9a337d...

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@durka
Copy link
Contributor Author

durka commented Sep 14, 2016

bogus

On Tue, Sep 13, 2016 at 10:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2490

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#36429 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAC3n9ZQNcuqp0KwY5HoGk9dq2SbGj-lks5qp15WgaJpZM4J7Edu
.

@alexcrichton
Copy link
Member

alexcrichton commented Sep 14, 2016

@bors: retry

On Tue, Sep 13, 2016 at 7:40 PM, Alex Burka notifications@github.com
wrote:

bogus

On Tue, Sep 13, 2016 at 10:39 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
<https://buildbot.rust-lang.org/builders/auto-win-msvc-64-
opt-rustbuild/builds/2490>

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#36429 (comment),
or mute
the thread
<https://github.com/notifications/unsubscribe-auth/
AAC3n9ZQNcuqp0KwY5HoGk9dq2SbGj-lks5qp15WgaJpZM4J7Edu>
.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36429 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95M3P666dUf3fqXLnw8zjIkj1NSEXks5qp16zgaJpZM4J7Edu
.

@Manishearth Manishearth mentioned this pull request Sep 15, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Sep 15, 2016
@Manishearth
Rollup merge of rust-lang#36429 - durka:patch-30, r=nagisa
23e0c24 
fix "X is not a member of trait Y" span labels

Fixes rust-lang#36428.
bors added a commit that referenced this pull request Sep 15, 2016
@bors
Auto merge of #36491 - Manishearth:rollup, r=Manishearth
dc75933 
Rollup of 9 pull requests

- Successful merges: #36384, #36405, #36425, #36429, #36438, #36454, #36459, #36461, #36463
- Failed merges: #36444
@bors bors merged commit 0a62676 into rust-lang:master Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arielb1 arielb1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@durka @rust-highfive @GuillaumeGomez @nikomatsakis @bors @alexcrichton @sophiajt @arielb1