Skip to content

Set run button transparent instead of invisible#36334

Merged
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:run_but
Sep 14, 2016
Merged

Set run button transparent instead of invisible#36334
bors merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:run_but

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Sep 7, 2016

r? @steveklabnik

And of course a screenshot:

screenshot from 2016-09-08 01-15-45

@steveklabnik
Copy link
Contributor

steveklabnik commented Sep 13, 2016

I am interested in giving this a try; I'm sure after it lands in a nightly, people will have opinions, and if it's hated, it's easy enough to revert.

To add some context for everyone else: after talking with a lot of newer Rust people, some of them didn't even notice that this button existed, so this is an attempt to make it more visible without being overwhelming.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 13, 2016

📌 Commit a2faf54 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

⌛ Testing commit a2faf54 with merge f1a090b...

@bors
Copy link
Collaborator

bors commented Sep 14, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@alexcrichton
Copy link
Member

alexcrichton commented Sep 14, 2016

@bors: retry

On Tue, Sep 13, 2016 at 8:25 PM, bors notifications@github.com wrote:

💔 Test failed - auto-win-msvc-64-opt-rustbuild
https://buildbot.rust-lang.org/builders/auto-win-msvc-64-opt-rustbuild/builds/2496

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36334 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAD95DWa3vb--I-NcjUy1yR4sUmI4bdCks5qp2k6gaJpZM4J3dIH
.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Sep 14, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Sep 14, 2016
@GuillaumeGomez
Rollup merge of rust-lang#36334 - GuillaumeGomez:run_but, r=steveklabnik
d939cbe 
Set run button transparent instead of invisible

r? @steveklabnik

And of course a screenshot:

![screenshot from 2016-09-08 01-15-45](https://cloud.githubusercontent.com/assets/3050060/18331849/31fe1f8c-7562-11e6-9ae9-1dab44089ec6.png)
bors added a commit that referenced this pull request Sep 14, 2016
@bors
Auto merge of #36472 - GuillaumeGomez:rollup, r=GuillaumeGomez
5a5736d 
Rollup of 5 pull requests

- Successful merges: #36334, #36335, #36363, #36374, #36467
- Failed merges:
@bors bors merged commit a2faf54 into rust-lang:master Sep 14, 2016
@GuillaumeGomez GuillaumeGomez deleted the run_but branch September 14, 2016 22:20
@bluss bluss mentioned this pull request Sep 21, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @steveklabnik @bors @alexcrichton