Merged
Conversation
Member
Manishearth
commented
Sep 4, 2016
- Successful merges: Update error format for E0458, E0459 #36070, Add --Zsave-analysis-api #36132, Fix incorrect LLVM Linkage enum #36200, Updated e0493 to new format (+ bonus). #36212, Update nightly docs supported Windows versions to match Getting Started page #36225, indicate where to copy config.toml.example #36231, rustbuild: add config.toml option to disable codegen tests #36234
- Failed merges:
- Fixes rust-lang#35933 - Part of rust-lang#35233 r? @jonathandturner
- Fixes rust-lang#35932 - Part of rust-lang#35233 r? @jonathandturner
Contributor
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors r+ p=10 |
Collaborator
|
📌 Commit a139242 has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Sep 4, 2016
Collaborator
|
💔 Test failed - auto-linux-64-opt-rustbuild |
Update error format for E0458, E0459 Fixes rust-lang#35933, rust-lang#35932 Part of rust-lang#35233 r? @jonathandturner
Add --Zsave-analysis-api This is a save-analysis variation which can be used with libraries distributed without their source (e.g., libstd). It will allow IDEs and other tools to get info about types and create URLs to docs and source, without the unnecessary clutter of internal-only save-analysis info. I'm sure we'll iterate somewhat on the design, but this is a first draft.
Member
Author
|
@bors r+ |
Collaborator
|
📌 Commit ad8b75b has been approved by |
Contributor
|
@Manishearth: I'm pretty sure the rollup will fail again since it still includes #36200 |
Collaborator
|
⌛ Testing commit ad8b75b with merge 1dbc1b9... |
Member
Author
|
Huh, thought I removed that @bors r+ force |
Collaborator
|
📌 Commit 55893f0 has been approved by |
…t, r=jonathandturner Updated e0493 to new format (+ bonus). Part of rust-lang#35233. Fixes rust-lang#35999. r? @jonathandturner I'm not satisfied with the bonus part, there has to be an easier way to reach into the `Drop`'s span implementation. I'm all ears. :)
…eklabnik Update nightly docs supported Windows versions to match Getting Started page https://doc.rust-lang.org/book/getting-started.html#tier-1 shows that Windows 7+ is officially supported (implying, for example Windows 10), but the nightly page only listed 7, 8, and Server 2008 R2).
indicate where to copy config.toml.example r? @alexcrichton
…xcrichton rustbuild: add config.toml option to disable codegen tests Fixes rust-lang#36232. I think it worked? Here's a build log where I tried to bootstrap, it crashed, then I added the setting to config.toml and it continued: https://gist.github.com/durka/cbf97cf04b8e065f1a2cfda4c1b6bf95 r? @alexcrichton
Collaborator
bors
added a commit
that referenced
this pull request
Sep 4, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.