r? @nrc

(rust_highfive has picked a reviewer for you, use r? to override)

r? @nikomatsakis

@eddyb

That and not hashing the SVH would mean that TypeId is stable, which I guess is needed for incremental recompilation, but a bit scary.

Why is that scary? It seems... right to me. The TypeId is basically just the "name" of a type, hence it is a nominal thing, no? Otherwise you have to deal with a lot of complexity around recursive types and so forth that doesn't seem worthwhile.

Note that the TypeId is only stable for a particular version of the crate/compiler -- not stable for all time. (If I have two versions of a crate foo, then foo:Foo will have 2 hashes, depending on which origin it comes from.)

@bors r+

📌 Commit 7bef809 has been approved by nikomatsakis

@bors r=nikomatsakis

📌 Commit d42da7b has been approved by nikomatsakis

⌛ Testing commit d42da7b with merge ecdd51b...

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-no-mir, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-no-mir, auto-win-msvc-64-opt-rustbuild
Approved by: nikomatsakis
Pushing ecdd51b to master...