Add doc examples for range::RangeArgument::{start,end}.#35041
Add doc examples for range::RangeArgument::{start,end}.#35041bors merged 1 commit intorust-lang:masterfrom
range::RangeArgument::{start,end}.#35041Conversation
src/libcollections/range.rs
Outdated
There was a problem hiding this comment.
It doesn't work without putting main function?
There was a problem hiding this comment.
extern crate and feature flags here shouldn't be within main, right?
There was a problem hiding this comment.
It shouldn't but it works and it is not (the generation is "clever" normally).
There was a problem hiding this comment.
It works because rustdoc knows what lines to extract and put them outside main?
There was a problem hiding this comment.
Thanks for the info! Fixed in the latest force push.
0b50a50 to
195de83
Compare
|
|
@GuillaumeGomez Check out the latest commit. It seems to fix the build. Have any idea why? I don't have too much time right now, so I might just squash the commits. |
|
No idea. Certainly because of the "extern crate". However, I'm a bit surprised there is an external import for collections. |
fb2c259 to
727d929
Compare
|
The situation of this trait is really strange, however it's used in @bors: r+ rollup |
|
📌 Commit 727d929 has been approved by |
|
⌛ Testing commit 727d929 with merge 1329da6... |
|
💔 Test failed - auto-win-msvc-64-opt-no-mir |
|
@bors: retry On Tue, Aug 2, 2016 at 12:09 PM, bors notifications@github.com wrote:
|
…llaumeGomez
Add doc examples for `range::RangeArgument::{start,end}`.
None
…llaumeGomez
Add doc examples for `range::RangeArgument::{start,end}`.
None
…llaumeGomez
Add doc examples for `range::RangeArgument::{start,end}`.
None
…llaumeGomez
Add doc examples for `range::RangeArgument::{start,end}`.
None
…llaumeGomez
Add doc examples for `range::RangeArgument::{start,end}`.
None
Rollup of 30 pull requests - Successful merges: #34319, #35041, #35042, #35076, #35109, #35137, #35175, #35181, #35182, #35189, #35239, #35264, #35266, #35281, #35285, #35289, #35291, #35294, #35296, #35297, #35298, #35299, #35318, #35319, #35324, #35326, #35328, #35333, #35359, #35362 - Failed merges:
No description provided.