Merged
Conversation
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
It now prints only unexpected errors and expected errors which weren't found
2d423c8 to
737d854
Compare
Member
Author
|
Actually, when a test fails, runtest prints ALL the errors he got and ALL the expected errors. When you only had 1 or 2 errors, it's quite easy to see what you forgot/didn't do correctly. However, when you have like 10 or more errors, it's just terrible. This PR changes the output, now only not found expected errors and unexpected errors are displayed. Everything else is unneeded and so, isn't displayed. |
Member
Author
|
original (yes, it took me a while to copy/paste): actual errors (from JSON output): [
Error {
line_num: 18,
kind: Some(
Error
),
msg: "18:42: 18:48: unknown meta item \'reason\' [E0541]"
}
// and every other errors
]
expected errors (from test file): [
Error {
line_num: 18,
kind: Some(
Error
),
msg: "unknown meta item \'reason\'"
}
// and every other expected errors
]new output: unexpected errors (from JSON output): [
Error {
line_num: 77,
kind: Some(
Error
),
msg: "77:3: 77:38: multiple stability levels [E0544]"
}
]
not found errors (from test file): [
Error {
line_num: 78,
kind: Some(
Error
),
msg: "multiple stability levels"
}
]Do you understand better? The second one only keeps the pertinent information. :) |
Contributor
|
LGTM |
Member
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 2, 2016
… r=alexcrichton Improve runtest output
bors
added a commit
that referenced
this pull request
Jul 2, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.