Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Hm I believe the intention of this test was to only test x86/x86_64 because the assembly is unlikely to work on other platforms, it's just a relic of our test harness that we require the same messages on all architectures.

Could this test be updated with something like // ignore-aarch64 instead?

If this test only works on x86/64, wouldn't that mean adding // ignore- for every platform? Isn't there something like // only-on-?

I mean, I see there's a #[cfg(any(target_arch = ...))], but it doesn't seem to work well with #[rustc_error]. I think this is the only test that uses rustc_error with cfg, by the way.

Yeah unfortunately we don't have // only yet (although I think there's an issue for it), but for now it should suffice to just have a few // ignore directives, the test suite largely isn't running on multiple architectures.

Ok, updated.

@bors: r+ ba8d46e rollup

Thanks!