Clarify docs for sort(&mut self)#33746
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gankro (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/libcollections/slice.rs
Outdated
|
I agree that the newline should be removed. The comma is fine, or fine to remove; I would probably write it, but I also know I tend towards using more commas than most people, and it reads fine either way. |
|
It's just details, but in this case, I think that the comma is slowing down my reading needlessly. |
|
Hm, I like the commas, the seperate the sentences so well. |
|
Oh, I noticed I use a lot of them myself 😄 Removed them. |
|
@bors: r+ rollup Thanks! |
|
📌 Commit bf8c070 has been approved by |
|
Thank you too! |
…abnik Clarify docs for sort(&mut self) I documented the memory usage like noted in this issue: * Document memory usage of sort() family of functions rust-lang#33419
I documented the memory usage like noted in this issue: