Doc fix: Update Cargo.toml in book/getting-started by deepak · Pull Request #32931 · rust-lang/rust

deepak · 2016-04-13T10:33:49Z

The Cargo.toml mentioned in book/getting-started
is missing the section called [dependencies]

rust-highfive · 2016-04-13T10:33:57Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

GuillaumeGomez · 2016-04-13T11:18:37Z

src/doc/book/getting-started.md

I find this sentence a bit awkward. What about "Do not worry about the [dependencies] line, we will come back to it later."?

thanks. reads better.
have made the change and rebased

The Cargo.toml mentioned in book/getting-started is missing the section called `[dependencies]`

GuillaumeGomez · 2016-04-13T11:45:23Z

Thanks!

r=me @steveklabnik

steveklabnik · 2016-04-13T14:25:16Z

@bors: delegate=@GuillaumeGomez

bors · 2016-04-13T14:25:16Z

✌️ @@GuillaumeGomez can now approve this pull request

bors · 2016-04-13T14:25:35Z

📌 Commit 722faa0 has been approved by guillaumegomez

steveklabnik · 2016-04-13T14:26:04Z

whoops

@bors: delegate=GuillaumeGomez

bors · 2016-04-13T14:26:05Z

✌️ @GuillaumeGomez can now approve this pull request

steveklabnik · 2016-04-13T14:26:12Z

@bors: r=GuillaumeGomez

bors · 2016-04-13T14:26:12Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Do not rely on file extensions after path canonicalization. #32828

bors · 2016-04-13T14:26:13Z

📌 Commit 722faa0 has been approved by GuillaumeGomez

bors · 2016-04-14T19:24:38Z

⌛ Testing commit 722faa0 with merge 21161a4...

bors · 2016-04-14T19:26:29Z

💔 Test failed - auto-win-gnu-32-opt

alexcrichton · 2016-04-14T20:08:35Z

@bors: retry

On Thu, Apr 14, 2016 at 12:26 PM, bors notifications@github.com wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/3790

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32931 (comment)

…in-getting-started-doc, r=GuillaumeGomez Doc fix: Update Cargo.toml in book/getting-started The Cargo.toml mentioned in book/getting-started is missing the section called `[dependencies]` fixes rust-lang#32928

Rollup of 11 pull requests - Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997 - Failed merges:

rust-highfive assigned steveklabnik Apr 13, 2016

GuillaumeGomez reviewed Apr 13, 2016
View reviewed changes

Doc fix: Update Cargo.toml in book/getting-started

722faa0

The Cargo.toml mentioned in book/getting-started is missing the section called `[dependencies]`

deepak force-pushed the gh-issue-32928-update-cargo-in-getting-started-doc branch from 0d87443 to 722faa0 Compare April 13, 2016 11:37

Manishearth mentioned this pull request Apr 15, 2016

Rollup of 11 pull requests #33005

Merged

bors added a commit that referenced this pull request Apr 15, 2016

Auto merge of #33005 - Manishearth:rollup, r=Manishearth

576229f

Rollup of 11 pull requests - Successful merges: #32923, #32926, #32929, #32931, #32935, #32945, #32946, #32964, #32970, #32973, #32997 - Failed merges:

bors merged commit 722faa0 into rust-lang:master Apr 16, 2016

Uh oh!

Conversation

deepak commented Apr 13, 2016

Uh oh!

rust-highfive commented Apr 13, 2016

Uh oh!

GuillaumeGomez Apr 13, 2016

Choose a reason for hiding this comment

Uh oh!

deepak Apr 13, 2016

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Apr 13, 2016

Uh oh!

steveklabnik commented Apr 13, 2016

Uh oh!

bors commented Apr 13, 2016

Uh oh!

bors commented Apr 13, 2016

Uh oh!

steveklabnik commented Apr 13, 2016

Uh oh!

bors commented Apr 13, 2016

Uh oh!

steveklabnik commented Apr 13, 2016

Uh oh!

bors commented Apr 13, 2016

Uh oh!

bors commented Apr 13, 2016

Uh oh!

bors commented Apr 14, 2016

Uh oh!

bors commented Apr 14, 2016

Uh oh!

alexcrichton commented Apr 14, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants