Reorganize rustc_front into rustc::hir. by eddyb · Pull Request #32570 · rust-lang/rust

eddyb · 2016-03-29T09:57:16Z

@nikomatsakis

Weed out dependencies on librustc_llvm and librustc. Found while working on #32570. cc @nikomatsakis

bors · 2016-03-30T01:04:35Z

☔ The latest upstream changes (presumably #32571) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2016-03-31T16:04:05Z

☔ The latest upstream changes (presumably #32439) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2016-03-31T19:52:16Z

☔ The latest upstream changes (presumably #31938) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2016-04-02T03:35:08Z

☔ The latest upstream changes (presumably #32666) made this pull request unmergeable. Please resolve the merge conflicts.

nagisa · 2016-04-02T11:43:32Z

mk/crates.mk

nit: alignment

EDIT: preexisting

bors · 2016-04-02T15:48:01Z

☔ The latest upstream changes (presumably #32562) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2016-04-04T14:02:52Z

src/librustc/hir/map/mod.rs

Note that some node-ids do not have a def-path, right? So this might panic?

nikomatsakis · 2016-04-04T14:04:36Z

This looks good to me, but I am concerned a bit about the last commit. We probably want to modify def_path_from_id to return an Option in the case that the node-id has no corresponding def-id.

eddyb · 2016-04-05T04:32:49Z

@nikomatsakis It's not used for nodes without a DefId AFAICT, but I made that change anyway.

nikomatsakis · 2016-04-05T12:22:18Z

@bors r+

bors · 2016-04-05T12:22:20Z

📌 Commit 4364907 has been approved by nikomatsakis

eddyb · 2016-04-06T06:20:31Z

@bors r=nikomatsakis

bors · 2016-04-06T06:20:33Z

📌 Commit 2c44fc4 has been approved by nikomatsakis

bors · 2016-04-06T07:11:28Z

⌛ Testing commit 2c44fc4 with merge 8be478c...

bors · 2016-04-06T07:14:09Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-04-06T07:14:10Z

⌛ Testing commit 2c44fc4 with merge 84c06a2...

bors · 2016-04-06T07:16:24Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-04-06T09:19:22Z

⌛ Testing commit 2c44fc4 with merge eb8f158...

bors · 2016-04-06T10:18:16Z

💔 Test failed - auto-linux-musl-64-opt

eddyb · 2016-04-06T10:46:54Z

@alexcrichton Above failure is legitimate but neither I, locally, nor Travis, actually hit it.
Do debuginfo tests not run if neither of gdb and lldb are installed?

eddyb · 2016-04-06T10:55:54Z

@bors r=nikomatsakis

bors · 2016-04-06T10:55:54Z

📌 Commit e8a8dfb has been approved by nikomatsakis

bors · 2016-04-06T11:23:02Z

⌛ Testing commit e8a8dfb with merge 2f4aef4...

bors · 2016-04-06T11:26:02Z

⛄ The build was interrupted to prioritize another pull request.

bors · 2016-04-06T11:38:07Z

⌛ Testing commit e8a8dfb with merge 4a49051...

@nikomatsakis

r? @nikomatsakis Conflicts: src/librustc_save_analysis/lib.rs src/libsyntax/ast_util.rs

bors · 2016-04-06T12:04:14Z

⛄ The build was interrupted to prioritize another pull request.

eddyb mentioned this pull request Mar 29, 2016

Weed out dependencies on librustc_llvm and librustc. #32571

Merged

bors added a commit that referenced this pull request Mar 29, 2016

Auto merge of #32571 - eddyb:llvm-back-to-back, r=alexcrichton

ec666a5

Weed out dependencies on librustc_llvm and librustc. Found while working on #32570. cc @nikomatsakis

eddyb force-pushed the tis-but-a-front branch 2 times, most recently from de55fa3 to 1e0df19 Compare March 31, 2016 15:20

eddyb force-pushed the tis-but-a-front branch from 1e0df19 to 6524703 Compare March 31, 2016 19:21

eddyb force-pushed the tis-but-a-front branch from 6524703 to dfcf05a Compare March 31, 2016 19:58

eddyb force-pushed the tis-but-a-front branch from dfcf05a to b5e97b1 Compare April 2, 2016 10:30

nikomatsakis self-assigned this Apr 2, 2016

nagisa reviewed Apr 2, 2016
View reviewed changes

mk/crates.mk Outdated

Copy link

Member

nagisa Apr 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: alignment

EDIT: preexisting

eddyb force-pushed the tis-but-a-front branch from b5e97b1 to 2ac08bf Compare April 3, 2016 10:30

nikomatsakis reviewed Apr 4, 2016
View reviewed changes

src/librustc/hir/map/mod.rs Outdated

Copy link

Contributor

nikomatsakis Apr 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that some node-ids do not have a def-path, right? So this might panic?

eddyb force-pushed the tis-but-a-front branch from 2ac08bf to 0de6c47 Compare April 5, 2016 04:28

eddyb force-pushed the tis-but-a-front branch from 0de6c47 to 4364907 Compare April 5, 2016 04:54

eddyb added 5 commits April 6, 2016 09:01

rustc: move rustc_front to rustc::hir.

8b09372

rustc: dismantle hir::util, mostly moving functions to methods.

ef4c724

syntax: dismantle ast_util.

7bebe80

rustc: move middle::{def,def_id,pat_util} to hir.

ffca6c3

rustc: move some maps from ty to hir.

20f0f3c

eddyb force-pushed the tis-but-a-front branch from 4364907 to 2c44fc4 Compare April 6, 2016 06:20

rustc: retire hir::map's paths.

e8a8dfb

eddyb force-pushed the tis-but-a-front branch from 2c44fc4 to e8a8dfb Compare April 6, 2016 10:52

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 6, 2016

Rollup merge of rust-lang#32570 - eddyb:tis-but-a-front, r=nikomatsakis

552af51

r? @nikomatsakis Conflicts: src/librustc_save_analysis/lib.rs src/libsyntax/ast_util.rs

bors merged commit e8a8dfb into rust-lang:master Apr 6, 2016

eddyb deleted the tis-but-a-front branch April 6, 2016 16:31

gyscos mentioned this pull request Apr 7, 2016

Doesn't build on nightly after rustc_front refactor mcoffin/syntaxext_lint#6

Closed

kc1212 mentioned this pull request May 1, 2016

Build fails with "can't find crate for rustc_front" canndrew/error_def#1

Closed

Uh oh!

Conversation

eddyb commented Mar 29, 2016

Uh oh!

bors commented Mar 30, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

bors commented Mar 31, 2016

Uh oh!

bors commented Apr 2, 2016

Uh oh!

nagisa Apr 2, 2016

Choose a reason for hiding this comment

Uh oh!

bors commented Apr 2, 2016

Uh oh!

nikomatsakis Apr 4, 2016

Choose a reason for hiding this comment

Uh oh!

nikomatsakis commented Apr 4, 2016

Uh oh!

eddyb commented Apr 5, 2016

Uh oh!

nikomatsakis commented Apr 5, 2016

Uh oh!

bors commented Apr 5, 2016

Uh oh!

eddyb commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

eddyb commented Apr 6, 2016

Uh oh!

eddyb commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

bors commented Apr 6, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants