Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
We may want to consider holding this off until after the release? It's super easy to backport a downgrade, however, so it may not be that critical. |
|
☔ The latest upstream changes (presumably #31846) made this pull request unmergeable. Please resolve the merge conflicts. |
6ae7423 to
93191cc
Compare
|
Just a note that 4.1.0 has just been released, so it might be worth going for that? |
93191cc to
c5fdd8d
Compare
|
Good point! I've rebased the jemalloc branch again |
|
r=me -- but I think at this point we might as well wait until the release |
…akis Now that jemalloc/jemalloc@767d850 is upstream, the relevant deadlocking issue which prompted our downgrade has been resolved. As a result, there's no known issue to *not* upgrade! This also re-enables jemalloc for the pc-windows-gnu target as known issues with that have also been fixed. Closes #31030
|
💔 Test failed - auto-linux-64-x-android-t |
c5fdd8d to
3069534
Compare
|
@bors: r=nikomatsakis 3069534fa76aa9f11c30e8483cccc467c3e880d4 |
|
⌛ Testing commit 3069534 with merge 97b2474... |
|
💔 Test failed - auto-linux-musl-64-opt |
Right now there's just a smattering of `// ignore-foo` platforms which is ever expanding as new ones are added. Instead switch to only running these tests on Linux/OSX and then use a guaranteed-to-work but not-as-well-tested alternative on other platforms.
3069534 to
df9e173
Compare
|
@bors: r=nikomatsakis df9e173 |
|
⌛ Testing commit df9e173 with merge 52e0bda... |
…akis Now that jemalloc/jemalloc@767d850 is upstream, the relevant deadlocking issue which prompted our downgrade has been resolved. As a result, there's no known issue to *not* upgrade! This also re-enables jemalloc for the pc-windows-gnu target as known issues with that have also been fixed. Closes #31030
Now that jemalloc/jemalloc@767d850 is upstream, the relevant deadlocking issue which prompted our downgrade has been resolved. As a result, there's no known issue to not upgrade! This also re-enables jemalloc for the pc-windows-gnu target as known issues with that have also been fixed.
Closes #31030