Add a new i586 Linux target#31629
Merged
bors merged 1 commit intorust-lang:masterfrom Feb 14, 2016
MagaTailor:master
Merged
Conversation
Contributor
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Author
Member
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Feb 13, 2016
This PR should make it easier to create a baseline x86 compiler as well as make cross-compilation possible through a separate set of rlibs. Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 13, 2016
This PR should make it easier to create a baseline x86 compiler as well as make cross-compilation possible through a separate set of rlibs. Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.
bors
added a commit
that referenced
this pull request
Feb 13, 2016
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Mar 4, 2016
Similarly to rust-lang#31629 where an i586-unknown-linux-gnu target was added, there is sometimes a desire to compile for x86 Windows as well where SSE2 is disabled. This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant for Windows as well. This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit Windows due to users having CPUs that don't support SSE2 instructions. It was requested that we could have non-SSE2 builds of the standard library available so they could continue to use vanilla releases and nightlies. [ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
bors
added a commit
that referenced
this pull request
Mar 11, 2016
rustc: Add an i586-pc-windows-msvc target Similarly to #31629 where an i586-unknown-linux-gnu target was added, there is sometimes a desire to compile for x86 Windows as well where SSE2 is disabled. This commit mirrors the i586-unknown-linux-gnu target and simply adds a variant for Windows as well. This is motivated by a recent [Gecko bug][ff] where crashes were seen on 32-bit Windows due to users having CPUs that don't support SSE2 instructions. It was requested that we could have non-SSE2 builds of the standard library available so they could continue to use vanilla releases and nightlies. [ff]: https://bugzilla.mozilla.org/show_bug.cgi?id=1253202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should make it easier to create a baseline x86 compiler as well as make cross-compilation possible through a separate set of rlibs.
Plus, a few Linux distributions (e.g. Debian) have voiced interest in having this target available.