Grammar improvements#24924
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 30, 2015
carols10cents:grammar-improvements
Merged
Grammar improvements#24924bors merged 3 commits intorust-lang:masterfrom carols10cents:grammar-improvements
bors merged 3 commits intorust-lang:masterfrom
carols10cents:grammar-improvements
Conversation
`enum_item` appeared in the `item` list but did not have an associated section; `const_item` had a section but did not appear in the list.
To make this rule match the definition of Lit_ in https://github.com/rust-lang/rust/blob/master/src/libsyntax/ast.rs
Reword so that the references to things above/below are up to date and a bit more specific.
Contributor
Collaborator
|
⌛ Testing commit 0ddee94 with merge b2ae102... |
Collaborator
|
💔 Test failed - auto-mac-64-nopt-t |
Member
|
@bors: retry On Thu, Apr 30, 2015 at 8:16 AM, bors notifications@github.com wrote:
|
Collaborator
bors
added a commit
that referenced
this pull request
Apr 30, 2015
I'm interested in helping out with #16676 but more in the grammar than the reference-- here's my first chunk, more to come!! 🎉 I did pull a bit *out* of the reference, though, that was more relevant to the grammar but wasn't moved over as part of #24729. I'm looking at, e.g. https://github.com/rust-lang/rust/blob/master/src/libsyntax/ast.rs, as the source of truth, please let me know if I should be checking against something else instead/in addition. r? @steveklabnik
Collaborator
Member
Author
|
😄 thank youuu! 💟 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm interested in helping out with #16676 but more in the grammar than the reference-- here's my first chunk, more to come!! 🎉
I did pull a bit out of the reference, though, that was more relevant to the grammar but wasn't moved over as part of #24729.
I'm looking at, e.g. https://github.com/rust-lang/rust/blob/master/src/libsyntax/ast.rs, as the source of truth, please let me know if I should be checking against something else instead/in addition.
r? @steveklabnik