Merged
Conversation
Member
Manishearth
commented
Apr 24, 2015
- Successful merges: Add backquotes to have better looking rust code #24523, remove debug and display chapter #24698, Explain how to create a Stdin or Stdout #24699, Fix a tiny typo in core::raw docs #24700, Remove stale comment #24706, rustdoc: add back [-]/[+] toggle links for unstable methods #24717, Fix quote tests #24718, Stop mentioning obsolete integer suffixes #24721, Audit reference manual: 5. Crates and source files #24727
- Failed merges:
this is too small for its own thing, I think.
`ToCStr` was removed with `old_io` and the current method `as_os_str` is inherent to `Path`, meaning there is no suitable trait bound that could be used here.
`us` and `is` were replaced with `usize` and `isize` some time ago.
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Member
Author
|
@bors: r+ force p=10 |
Collaborator
|
📌 Commit f772079 has been approved by |
Member
Author
|
@bors: force |
bors
added a commit
that referenced
this pull request
Apr 24, 2015
Collaborator
|
⌛ Testing commit f772079 with merge 2efcd0b... |
Collaborator
|
💔 Test failed - auto-mac-32-opt |
Member
Author
|
@bors: r+ p=10 |
Collaborator
|
📌 Commit 874e093 has been approved by |
Collaborator
|
⌛ Testing commit 874e093 with merge f90f9e8... |
Collaborator
|
💔 Test failed - auto-mac-64-nopt-t |
Member
Author
|
@bors: r+ p=10 |
Collaborator
|
📌 Commit 874e093 has been approved by |
Member
Author
|
@bors: force |
1 similar comment
Member
Author
|
@bors: force |
Member
Author
|
@bors: r+ p=10 |
Collaborator
|
📌 Commit 874e093 has been approved by |
Member
Author
|
@bors: retry ah |
Collaborator
|
⌛ Testing commit 874e093 with merge 71c92fa... |
Collaborator
|
💔 Test failed - auto-linux-64-nopt-t |
Member
Author
|
@bors: r+ force |
Collaborator
|
📌 Commit ae3c27c has been approved by |
Collaborator
|
⌛ Testing commit ae3c27c with merge 1f52dee... |
Collaborator
|
💔 Test failed - auto-mac-64-opt |
Member
Author
|
@bors: r+ force |
Collaborator
|
📌 Commit 1447ee4 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 24, 2015
Collaborator
…r=steveklabnik this is too small for its own thing, I think.
…ichton `ToCStr` was removed with `old_io` and the current method `as_os_str` is inherent to `Path`, meaning there is no suitable trait bound that could be used here. r? @alexcrichton
…crichton r? @alexcrichton (since you added `.stability` warning messages)
`us` and `is` were replaced with `usize` and `isize` some time ago. Other than that, 3.5.2.1.5 is correct.
…bnik It was in pretty good shape, but since that is my pet peeve, I clarified the compiler/interpreter distinction and why it is irrelevant for this section. Otherwise only a couple of minor clarifications, and weasel words where reality is more complicated than the text accounted for (e.g., there is more than one kind of library). r? @steveklabnik
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.