Change the type of constants BYTES/BITS to usize#23832
Merged
bors merged 3 commits intorust-lang:masterfrom Apr 3, 2015
Merged
Change the type of constants BYTES/BITS to usize#23832bors merged 3 commits intorust-lang:masterfrom
bors merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
|
☔ The latest upstream changes (presumably #23831) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
Collaborator
bors
added a commit
that referenced
this pull request
Apr 3, 2015
These constants are small and can fit even in `u8`, but semantically they have type `usize` because they denote sizes and are almost always used in `usize` context. The change of their type to `u32` during the integer audit led only to the large amount of `as usize` noise (see the second commit, which removes this noise). This is a minor [breaking-change] to an unstable interface. r? @aturon
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These constants are small and can fit even in
u8, but semantically they have typeusizebecause they denote sizes and are almost always used inusizecontext. The change of their type tou32during the integer audit led only to the large amount ofas usizenoise (see the second commit, which removes this noise).This is a minor [breaking-change] to an unstable interface.
r? @aturon