Skip to content

debuginfo: Add GDB pretty printers for slices, Vec<>, and String.#23310

Merged
bors merged 1 commit intorust-lang:masterfrom
michaelwoerister:gdb-std-pp
Mar 13, 2015
Merged

debuginfo: Add GDB pretty printers for slices, Vec<>, and String.#23310
bors merged 1 commit intorust-lang:masterfrom
michaelwoerister:gdb-std-pp

Conversation

@michaelwoerister
Copy link
Member

@michaelwoerister michaelwoerister commented Mar 12, 2015 

Rust:  let slice: &[i32] = &[0, 1, 2, 3];
GDB:   $1 = &[i32](len: 4) = {0, 1, 2, 3}

Rust:  let vec = vec![4, 5, 6, 7];
GDB:   $2 = Vec<u64>(len: 4, cap: 4) = {4, 5, 6, 7}

Rust:  let str_slice = "IAMA string slice!";
GDB:   $3 = "IAMA string slice!"

Rust:  let string = "IAMA string!".to_string();
GDB:   $4 = "IAMA string!"

Neat!

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 12, 2015

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

alexcrichton commented Mar 12, 2015

@bors: r+ 90fc28d

Nice!

@Manishearth
Copy link
Member

Manishearth commented Mar 12, 2015

👯

@eddyb
Copy link
Member

eddyb commented Mar 13, 2015

I wonder if it would be possible for &[i32](len: 4) to be printed as &[i32; 4] instead, as if unsizing was being reversed.

@michaelwoerister
Copy link
Member Author

michaelwoerister commented Mar 13, 2015

@eddyb We could do that but it would be kind of lying about the type, wouldn't it?

@eddyb
Copy link
Member

eddyb commented Mar 13, 2015

I guess... I prefer {len: 4, cap: 4} for what it's worth, but that's really unimportant.

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 13, 2015
@Manishearth
Rollup merge of rust-lang#23310 - michaelwoerister:gdb-std-pp, r=alex…
6354387 
…crichton

 ```rust
Rust:  let slice: &[i32] = &[0, 1, 2, 3];
GDB:   $1 = &[i32](len: 4) = {0, 1, 2, 3}

Rust:  let vec = vec![4, 5, 6, 7];
GDB:   $2 = Vec<u64>(len: 4, cap: 4) = {4, 5, 6, 7}

Rust:  let str_slice = \"IAMA string slice!\";
GDB:   $3 = \"IAMA string slice!\"

Rust:  let string = \"IAMA string!\".to_string();
GDB:   $4 = \"IAMA string!\"
```
Neat!
@michaelwoerister
Copy link
Member Author

michaelwoerister commented Mar 13, 2015

I guess... I prefer {len: 4, cap: 4} for what it's worth, but that's really unimportant.

Yes, I think I'll do some kind of informal poll in the forum about what the actual rendering should look like.

@bors bors merged commit 90fc28d into rust-lang:master Mar 13, 2015
@saethlin saethlin mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pcwalton pcwalton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@michaelwoerister @rust-highfive @alexcrichton @Manishearth @eddyb @pcwalton @bors