disabling jemalloc on bitrig#23255
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ 074f094 rollup |
|
While compiling Rust from source on Bitrig using a Rust snapshot built with jemalloc enabled, I get a lot of errors that look like this: It doesn't seem to affect Rust functionality but it sure looks scary. Like I said, I'm disabling jemalloc on Bitrig until I know what is causing this and I upstream the patches to jemalloc. |
|
@dhuseby I don't known if it is related, but under openbsd I use the following patch https://github.com/jasperla/openbsd-wip/blob/master/lang/rustc/patches/patch-src_jemalloc_configure for building jemalloc. The latest version of jemalloc proper detect the lake of tls (thread-local-storage), but not the version used by rust. I hope this could help you. |
|
@semarie that might fix the problem. i'll give it a try soon. i did notice that without jemalloc, several of my test apps ran noticeably (wall clock) faster. But that may have been because jemalloc was broken. |
|
@nikomatsakis sorry for confusing things a bit, a new snapshot for bitrig was just uploaded and i added it to the snapshots.txt file and bumped llvm-auto-clean-trigger too. |
|
@nikomatsakis both disabling jemalloc and the new snapshot are needed to get the bitrig buildbot working properly. |
|
You should be able to leave out the |
|
@alexcrichton aha! ok, I see. |
|
OK, I reverted the bump in llvm-auto-clean-trigger and rebased to the current master HEAD. |
|
Could you peel off the last two commits as well? Otherwise r=me, thanks! |
|
@alexcrichton sure |
|
@bors: r+ c005f8a2f1022679ab3fb4353e12cc795f04a9a0 |
src/snapshots.txt
Outdated
There was a problem hiding this comment.
the name is invalid: it should be bitrig (missing t)
|
@semarie good catch! corrected. |
|
rebased to current master HEAD. |
it turns out that jemalloc doesn't behave well on bitrig. with jemalloc enabled i get some kernel errors related to sbrk failures. with jemalloc disabled, the errors go away. i am investigating, but in the mean time, we should just disable jemalloc by default on bitrig.
it turns out that jemalloc doesn't behave well on bitrig. with jemalloc enabled i get some kernel errors related to sbrk failures. with jemalloc disabled, the errors go away. i am investigating, but in the mean time, we should just disable jemalloc by default on bitrig.