Slice::swap should be inlineable#22988
Merged
bors merged 1 commit intorust-lang:masterfrom Mar 3, 2015
Merged
Conversation
Contributor
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Member
|
@bors: r+ 1d647a0 rollup |
Contributor
|
Did you have any indication it was not inlinable? It's a generic method, so it has to be inlinable already. |
Contributor
Author
|
I'm under the impression that without the inline attribute, llvm will not consider inlining a function cross-crate. |
Member
|
Ah yes @bluss I forgot to note that! @dcrewi all generics are instantiated downstream with concrete types and are hence available for inlining. Functions which are otherwise not able to cross crates (e.g. those that have no generics) are not candidates for inlining and hence require the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.